Fix visit marker race condition #7082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielblando
force-pushed
the
compactor-race-condition
branch
from
fc25ae6 to
608c59c
Compare
Signed-off-by: Daniel Deluiggi <[email protected]>
danielblando
force-pushed
the
compactor-race-condition
branch
from
608c59c to
17a44b9
Compare
anna-tran
approved these changes
Oct 31, 2025
Contributor
anna-tran
left a comment
anna-tran
left a comment
There was a problem hiding this comment.
Nice, thanks for fixing this!
yeya24
reviewed
Oct 31, 2025
Signed-off-by: Daniel Deluiggi <[email protected]>
danielblando
force-pushed
the
compactor-race-condition
branch
from
c7c99f6 to
e091106
Compare
This was referenced Nov 1, 2025
yeya24
pushed a commit
to yeya24/cortex
that referenced
this pull request
Nov 4, 2025
3 tasks
yeya24
added a commit
that referenced
this pull request
Nov 4, 2025
* Fix metric name validation to use correct validation scheme method (#7087) Signed-off-by: Anna Tran <[email protected]> * bump to 1.20.0-rc.1 Signed-off-by: yeya24 <[email protected]> * Fix visit marker race condition (#7082) * update changelog Signed-off-by: yeya24 <[email protected]> --------- Signed-off-by: Anna Tran <[email protected]> Signed-off-by: yeya24 <[email protected]> Co-authored-by: Anna Tran <[email protected]> Co-authored-by: Daniel Blando <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Introduce new check if grouper still exist before planner allow compactor to start to prevent race condition on compactor focusing on the short term proposed on #7075
Which issue(s) this PR fixes:
Fixes #7075
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]