From 286bcd9704026d801c5f6af02abb1ca337479333 Mon Sep 17 00:00:00 2001 From: SungJin1212 Date: Tue, 25 Nov 2025 14:10:42 +0900 Subject: [PATCH 1/3] Add tracings to parquet bucket store Signed-off-by: SungJin1212 --- CHANGELOG.md | 1 + pkg/storegateway/parquet_bucket_store.go | 11 ++++++++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8fb3173869..3647fcbd2e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ ## master / unreleased * [FEATURE] StoreGateway: Introduces a new parquet mode. #7046 +* [ENHANCEMENT] StoreGateway: Add tracings to parquet mode. #7125 * [ENHANCEMENT] Alertmanager: Upgrade alertmanger to 0.29.0 and add a new incidentIO integration. #7092 * [ENHANCEMENT] Querier: Add a `-querier.parquet-queryable-shard-cache-ttl` flag to add TTL to parquet shard cache. #7098 * [ENHANCEMENT] Ingester: Add `enable_matcher_optimization` config to apply low selectivity matchers lazily. #7063 diff --git a/pkg/storegateway/parquet_bucket_store.go b/pkg/storegateway/parquet_bucket_store.go index df005b01a8..adc809cc9a 100644 --- a/pkg/storegateway/parquet_bucket_store.go +++ b/pkg/storegateway/parquet_bucket_store.go @@ -5,6 +5,7 @@ import ( "fmt" "strings" + "github.com/cortexproject/cortex/pkg/util/spanlogger" "github.com/go-kit/log" "github.com/gogo/protobuf/types" "github.com/pkg/errors" @@ -73,12 +74,14 @@ func (p *parquetBucketStore) findParquetBlocks(ctx context.Context, blockMatcher // Series implements the store interface for a single parquet bucket store func (p *parquetBucketStore) Series(req *storepb.SeriesRequest, srv storepb.Store_SeriesServer) (err error) { + spanLog, ctx := spanlogger.New(srv.Context(), "ParquetBucketStore.Series") + defer spanLog.Finish() + matchers, err := storecache.MatchersToPromMatchersCached(p.matcherCache, req.Matchers...) if err != nil { return status.Error(codes.InvalidArgument, err.Error()) } - ctx := srv.Context() resHints := &hintspb.SeriesResponseHints{} var anyHints *types.Any @@ -158,6 +161,9 @@ func (p *parquetBucketStore) Series(req *storepb.SeriesRequest, srv storepb.Stor // LabelNames implements the store interface for a single parquet bucket store func (p *parquetBucketStore) LabelNames(ctx context.Context, req *storepb.LabelNamesRequest) (*storepb.LabelNamesResponse, error) { + spanLog, ctx := spanlogger.New(ctx, "ParquetBucketStore.LabelNames") + defer spanLog.Finish() + matchers, err := storecache.MatchersToPromMatchersCached(p.matcherCache, req.Matchers...) if err != nil { return nil, status.Error(codes.InvalidArgument, err.Error()) @@ -213,6 +219,9 @@ func (p *parquetBucketStore) LabelNames(ctx context.Context, req *storepb.LabelN // LabelValues implements the store interface for a single parquet bucket store func (p *parquetBucketStore) LabelValues(ctx context.Context, req *storepb.LabelValuesRequest) (*storepb.LabelValuesResponse, error) { + spanLog, ctx := spanlogger.New(ctx, "ParquetBucketStore.LabelValues") + defer spanLog.Finish() + matchers, err := storecache.MatchersToPromMatchersCached(p.matcherCache, req.Matchers...) if err != nil { return nil, status.Error(codes.InvalidArgument, err.Error()) From 27c3f62bdfb01feea8cad5ea045f7e4ad7f73e90 Mon Sep 17 00:00:00 2001 From: SungJin1212 Date: Tue, 25 Nov 2025 14:14:01 +0900 Subject: [PATCH 2/3] fix lint Signed-off-by: SungJin1212 --- pkg/storegateway/parquet_bucket_store.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/storegateway/parquet_bucket_store.go b/pkg/storegateway/parquet_bucket_store.go index adc809cc9a..cc7d83f9dc 100644 --- a/pkg/storegateway/parquet_bucket_store.go +++ b/pkg/storegateway/parquet_bucket_store.go @@ -5,7 +5,6 @@ import ( "fmt" "strings" - "github.com/cortexproject/cortex/pkg/util/spanlogger" "github.com/go-kit/log" "github.com/gogo/protobuf/types" "github.com/pkg/errors" @@ -26,6 +25,7 @@ import ( "google.golang.org/grpc/codes" "google.golang.org/grpc/status" + "github.com/cortexproject/cortex/pkg/util/spanlogger" "github.com/cortexproject/cortex/pkg/util/validation" ) From 5a0c54efb98b102c6e263da9eba81b2c610c5d36 Mon Sep 17 00:00:00 2001 From: SungJin1212 Date: Tue, 25 Nov 2025 14:57:09 +0900 Subject: [PATCH 3/3] fix lint Signed-off-by: SungJin1212 --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3647fcbd2e..f6cf4a5245 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,7 +3,7 @@ ## master / unreleased * [FEATURE] StoreGateway: Introduces a new parquet mode. #7046 -* [ENHANCEMENT] StoreGateway: Add tracings to parquet mode. #7125 +* [ENHANCEMENT] StoreGateway: Add tracings to parquet mode. #7125 * [ENHANCEMENT] Alertmanager: Upgrade alertmanger to 0.29.0 and add a new incidentIO integration. #7092 * [ENHANCEMENT] Querier: Add a `-querier.parquet-queryable-shard-cache-ttl` flag to add TTL to parquet shard cache. #7098 * [ENHANCEMENT] Ingester: Add `enable_matcher_optimization` config to apply low selectivity matchers lazily. #7063