Skip to content

Commit 26fd3e9

Browse files
committed
Fix linters
Signed-off-by: Friedrich Gonzalez <[email protected]>
1 parent 4fc42f2 commit 26fd3e9

File tree

15 files changed

+30
-736
lines changed

15 files changed

+30
-736
lines changed

.golangci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
version: "2"

exec/exec.go

Lines changed: 0 additions & 35 deletions
This file was deleted.

fs/fs.go

Lines changed: 0 additions & 99 deletions
This file was deleted.

fs/fs_test.go

Lines changed: 0 additions & 81 deletions
This file was deleted.

fs/readdircount_linux_amd64.go

Lines changed: 0 additions & 62 deletions
This file was deleted.

fs/readdircount_unsupported.go

Lines changed: 0 additions & 9 deletions
This file was deleted.

go.mod

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
module github.com/weaveworks/common
22

3-
go 1.22
4-
5-
toolchain go1.23.2
3+
go 1.24
64

75
require (
86
github.com/armon/go-socks5 v0.0.0-20160902184237-e75332964ef5

httpgrpc/server/server_test.go

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,8 @@ func newTestServer(handler http.Handler) (*testServer, error) {
4646

4747
func TestBasic(t *testing.T) {
4848
server, err := newTestServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
49-
fmt.Fprint(w, "world")
49+
_, err := fmt.Fprint(w, "world")
50+
require.NoError(t, err)
5051
}))
5152
require.NoError(t, err)
5253
defer server.grpcServer.GracefulStop()
@@ -115,12 +116,16 @@ func TestTracePropagation(t *testing.T) {
115116
jaeger := jaegercfg.Configuration{}
116117
closer, err := jaeger.InitGlobalTracer("test")
117118
require.NoError(t, err)
118-
defer closer.Close()
119+
defer func() {
120+
err := closer.Close()
121+
require.NoError(t, err)
122+
}()
119123

120124
server, err := newTestServer(middleware.Tracer{}.Wrap(
121125
http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
122126
span := opentracing.SpanFromContext(r.Context())
123-
fmt.Fprint(w, span.BaggageItem("name"))
127+
_, err := fmt.Fprint(w, span.BaggageItem("name"))
128+
require.NoError(t, err)
124129
}),
125130
))
126131

0 commit comments

Comments
 (0)