@@ -134,7 +134,7 @@ def __init__(self, n_e, ssa=False):
134134 self ._emission_region_pars_names = list (emission_region_pars .keys ())
135135
136136 # group the model parameters, add the norm at the bottom of the list
137- norm = Parameter ("norm" , 1 , min = 0.1 , max = 10 , is_norm = True , frozen = True )
137+ norm = Parameter ("norm" , 1 , min = 0.1 , max = 10 , frozen = True )
138138 self .default_parameters = Parameters (
139139 [* spectral_pars .values (), * emission_region_pars .values (), norm ]
140140 )
@@ -163,7 +163,7 @@ def evaluate(self, energy, **kwargs):
163163 NOTE: All the model parameters will be passed as kwargs by
164164 SpectralModel.evaluate()."""
165165
166- nu = energy .to ("Hz" , equivalencies = u .spectral ())
166+ nu = energy .reshape ([ energy . shape [ 0 ]]). to ("Hz" , equivalencies = u .spectral ())
167167
168168 args = _sort_spectral_parameters (self ._spectral_pars_names , self ._n_e , ** kwargs )
169169 z , d_L , delta_D , B , R_b = _sort_emission_region_parameters ("ssc" , ** kwargs )
@@ -180,15 +180,8 @@ def evaluate(self, energy, **kwargs):
180180 )
181181 sed = sed_synch + sed_ssc
182182
183- # to avoid the problem pointed out in
184- # https://github.com/cosimoNigro/agnpy/issues/117
185- # we can do here something like
186- # sed = sed.reshape(energy.shape)
187- # this is done in Gammapy's `NaimaSpectralModel`
188- # https://github.com/gammapy/gammapy/blob/master/gammapy/modeling/models/spectral.py#L2119
189-
190183 # gammapy requires a differential flux in input
191- return (sed / energy ** 2 ).to ("1 / (cm2 eV s)" )
184+ return (sed . reshape ( energy . shape ) / energy ** 2 ).to ("1 / (cm2 eV s)" )
192185
193186
194187class ExternalComptonSpectralModel (SpectralModel ):
@@ -234,7 +227,7 @@ def __init__(self, n_e, targets, ssa=False):
234227 self ._targets_pars_names = list (targets_pars .keys ())
235228
236229 # group the model parameters, add the norm at the bottom of the list
237- norm = Parameter ("norm" , 1 , min = 0.1 , max = 10 , is_norm = True , frozen = True )
230+ norm = Parameter ("norm" , 1 , min = 0.1 , max = 10 , frozen = True )
238231 self .default_parameters = Parameters (
239232 [
240233 * spectral_pars .values (),
@@ -295,8 +288,7 @@ def evaluate(self, energy, **kwargs):
295288 """Evaluate the SED model.
296289 NOTE: All the model parameters will be passed as kwargs by
297290 SpectralModel.evaluate()."""
298-
299- nu = energy .to ("Hz" , equivalencies = u .spectral ())
291+ nu = energy .reshape ([energy .shape [0 ]]).to ("Hz" , equivalencies = u .spectral ())
300292
301293 args = _sort_spectral_parameters (self ._spectral_pars_names , self ._n_e , ** kwargs )
302294 z , d_L , delta_D , B , R_b , mu_s , r = _sort_emission_region_parameters (
@@ -365,9 +357,4 @@ def evaluate(self, energy, **kwargs):
365357 )
366358 sed += sed_bb_dt
367359
368- # eventual reshaping
369- # we can do here something like
370- # sed = sed.reshape(energy.shape)
371- # see the same comment in the SSC model
372-
373- return (sed / energy ** 2 ).to ("1 / (cm2 eV s)" )
360+ return (sed .reshape (energy .shape ) / energy ** 2 ).to ("1 / (cm2 eV s)" )
0 commit comments