fit tests

Author: cosmic-bytes

.github/workflows/ci.yml

@@ -24,7 +24,7 @@ jobs:
         go-version: ${{ env.GO_VERSION }}
 
     - name: Cache Go modules
-      uses: actions/cache@v3
+      uses: actions/cache@v4
       with:
         path: |
           ~/.cache/go-build
@@ -40,7 +40,7 @@ jobs:
       uses: golangci/golangci-lint-action@v3
       with:
         version: latest
-        args: --timeout=5m
+        args: --timeout=5m --out-format=colored-line-number
 
     - name: Check formatting
       run: |
@@ -171,7 +171,7 @@ jobs:
         fail_ci_if_error: false
 
     - name: Upload coverage reports as artifact
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: coverage-reports
         path: |
@@ -237,7 +237,7 @@ jobs:
       run: make test-performance
 
     - name: Upload performance profiles as artifacts
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: performance-profiles
         path: |

.github/workflows/release.yml

@@ -29,7 +29,7 @@ jobs:
         id: current_version
         run: |
           CURRENT_VERSION=$(grep -o 'version.*=.*"[^"]*"' main.go | cut -d'"' -f2)
-          echo "current=$CURRENT_VERSION" >> $GITHUB_OUTPUT
+          echo "current=$CURRENT_VERSION" >> "$GITHUB_OUTPUT"
 
       - name: Bump version
         id: version
@@ -40,9 +40,17 @@ jobs:
           MINOR=${PARTS[1]}
           PATCH=${PARTS[2]}
           NEW_PATCH=$((PATCH + 1))
+          
+          # Keep incrementing until we find an available tag
+          while git ls-remote --tags origin | grep -q "refs/tags/v$MAJOR.$MINOR.$NEW_PATCH"; do
+            echo "Tag v$MAJOR.$MINOR.$NEW_PATCH already exists, incrementing..."
+            NEW_PATCH=$((NEW_PATCH + 1))
+          done
+          
           NEW_VERSION="$MAJOR.$MINOR.$NEW_PATCH"
-          echo "version=$NEW_VERSION" >> $GITHUB_OUTPUT
-          echo "tag=v$NEW_VERSION" >> $GITHUB_OUTPUT
+          echo "Using version: $NEW_VERSION"
+          echo "version=$NEW_VERSION" >> "$GITHUB_OUTPUT"
+          echo "tag=v$NEW_VERSION" >> "$GITHUB_OUTPUT"
 
       - name: Update version in code
         run: |

internal/config/config.go

@@ -101,4 +101,4 @@ func (m *Manager) GetRule(id string) *models.SyncRule {
 		}
 	}
 	return nil
-}
+}

internal/config/config_test.go

@@ -11,23 +11,23 @@ import (
 
 func TestNew(t *testing.T) {
 	cfg := New()
-	
+
 	if cfg == nil {
 		t.Fatal("New() returned nil")
 	}
-	
+
 	if cfg.Rules == nil {
 		t.Error("Rules slice is nil")
 	}
-	
+
 	if len(cfg.Rules) != 0 {
 		t.Errorf("Expected empty rules slice, got %d rules", len(cfg.Rules))
 	}
-	
+
 	if cfg.LogFile != "var-sync.log" {
 		t.Errorf("Expected LogFile to be 'var-sync.log', got %s", cfg.LogFile)
 	}
-	
+
 	if cfg.Debug {
 		t.Error("Expected Debug to be false")
 	}
@@ -36,16 +36,16 @@ func TestNew(t *testing.T) {
 func TestLoadNonExistentFile(t *testing.T) {
 	tempDir := t.TempDir()
 	configPath := filepath.Join(tempDir, "test-config.json")
-	
+
 	cfg, err := Load(configPath)
 	if err != nil {
 		t.Fatalf("Load() returned error: %v", err)
 	}
-	
+
 	if cfg == nil {
 		t.Fatal("Load() returned nil config")
 	}
-	
+
 	// Verify file was created
 	if _, err := os.Stat(configPath); os.IsNotExist(err) {
 		t.Error("Config file was not created")
@@ -55,7 +55,7 @@ func TestLoadNonExistentFile(t *testing.T) {
 func TestLoadExistingFile(t *testing.T) {
 	tempDir := t.TempDir()
 	configPath := filepath.Join(tempDir, "test-config.json")
-	
+
 	// Create test config
 	testRule := models.SyncRule{
 		ID:          "test-rule",
@@ -68,36 +68,36 @@ func TestLoadExistingFile(t *testing.T) {
 		Enabled:     true,
 		Created:     time.Now(),
 	}
-	
+
 	testConfig := &models.Config{
 		Rules:   []models.SyncRule{testRule},
 		LogFile: "test.log",
 		Debug:   true,
 	}
-	
+
 	// Save test config
 	if err := Save(testConfig, configPath); err != nil {
 		t.Fatalf("Failed to save test config: %v", err)
 	}
-	
+
 	// Load config
 	cfg, err := Load(configPath)
 	if err != nil {
 		t.Fatalf("Load() returned error: %v", err)
 	}
-	
+
 	if len(cfg.Rules) != 1 {
 		t.Errorf("Expected 1 rule, got %d", len(cfg.Rules))
 	}
-	
+
 	if cfg.Rules[0].ID != "test-rule" {
 		t.Errorf("Expected rule ID 'test-rule', got %s", cfg.Rules[0].ID)
 	}
-	
+
 	if cfg.LogFile != "test.log" {
 		t.Errorf("Expected LogFile 'test.log', got %s", cfg.LogFile)
 	}
-	
+
 	if !cfg.Debug {
 		t.Error("Expected Debug to be true")
 	}
@@ -106,30 +106,30 @@ func TestLoadExistingFile(t *testing.T) {
 func TestSave(t *testing.T) {
 	tempDir := t.TempDir()
 	configPath := filepath.Join(tempDir, "subdir", "test-config.json")
-	
+
 	cfg := New()
 	cfg.LogFile = "custom.log"
 	cfg.Debug = true
-	
+
 	if err := Save(cfg, configPath); err != nil {
 		t.Fatalf("Save() returned error: %v", err)
 	}
-	
+
 	// Verify file exists
 	if _, err := os.Stat(configPath); os.IsNotExist(err) {
 		t.Error("Config file was not created")
 	}
-	
+
 	// Load and verify content
 	loadedCfg, err := Load(configPath)
 	if err != nil {
 		t.Fatalf("Failed to load saved config: %v", err)
 	}
-	
+
 	if loadedCfg.LogFile != "custom.log" {
 		t.Errorf("Expected LogFile 'custom.log', got %s", loadedCfg.LogFile)
 	}
-	
+
 	if !loadedCfg.Debug {
 		t.Error("Expected Debug to be true")
 	}
@@ -138,22 +138,22 @@ func TestSave(t *testing.T) {
 func TestManager(t *testing.T) {
 	tempDir := t.TempDir()
 	configPath := filepath.Join(tempDir, "manager-test.json")
-	
+
 	manager, err := NewManager(configPath)
 	if err != nil {
 		t.Fatalf("NewManager() returned error: %v", err)
 	}
-	
+
 	if manager == nil {
 		t.Fatal("NewManager() returned nil")
 	}
-	
+
 	// Test Config() method
 	cfg := manager.Config()
 	if cfg == nil {
 		t.Error("Config() returned nil")
 	}
-	
+
 	// Test AddRule
 	testRule := models.SyncRule{
 		ID:          "manager-test-rule",
@@ -166,54 +166,54 @@ func TestManager(t *testing.T) {
 		Enabled:     true,
 		Created:     time.Now(),
 	}
-	
+
 	manager.AddRule(testRule)
-	
+
 	if len(manager.Config().Rules) != 1 {
 		t.Errorf("Expected 1 rule after AddRule, got %d", len(manager.Config().Rules))
 	}
-	
+
 	// Test GetRule
 	rule := manager.GetRule("manager-test-rule")
 	if rule == nil {
 		t.Error("GetRule() returned nil for existing rule")
 	}
-	
+
 	if rule.ID != "manager-test-rule" {
 		t.Errorf("Expected rule ID 'manager-test-rule', got %s", rule.ID)
 	}
-	
+
 	// Test GetRule with non-existent ID
 	nonExistentRule := manager.GetRule("non-existent")
 	if nonExistentRule != nil {
 		t.Error("GetRule() should return nil for non-existent rule")
 	}
-	
+
 	// Test Save
 	if err := manager.Save(); err != nil {
 		t.Errorf("Save() returned error: %v", err)
 	}
-	
+
 	// Test RemoveRule
 	manager.RemoveRule("manager-test-rule")
-	
+
 	if len(manager.Config().Rules) != 0 {
 		t.Errorf("Expected 0 rules after RemoveRule, got %d", len(manager.Config().Rules))
 	}
-	
+
 	// Test removing non-existent rule (should not panic)
 	manager.RemoveRule("non-existent")
 }
 
 func TestLoadInvalidJSON(t *testing.T) {
 	tempDir := t.TempDir()
 	configPath := filepath.Join(tempDir, "invalid.json")
-	
+
 	// Write invalid JSON
 	if err := os.WriteFile(configPath, []byte("invalid json"), 0644); err != nil {
 		t.Fatalf("Failed to write invalid JSON: %v", err)
 	}
-	
+
 	_, err := Load(configPath)
 	if err == nil {
 		t.Error("Load() should return error for invalid JSON")
@@ -223,14 +223,14 @@ func TestLoadInvalidJSON(t *testing.T) {
 func TestSaveWithMissingDirectory(t *testing.T) {
 	tempDir := t.TempDir()
 	configPath := filepath.Join(tempDir, "missing", "dir", "config.json")
-	
+
 	cfg := New()
 	if err := Save(cfg, configPath); err != nil {
 		t.Errorf("Save() should create missing directories, got error: %v", err)
 	}
-	
+
 	// Verify file was created
 	if _, err := os.Stat(configPath); os.IsNotExist(err) {
 		t.Error("Config file was not created in missing directory")
 	}
-}
+}

internal/logger/logger.go

@@ -64,7 +64,7 @@ func (l *Logger) log(level LogLevel, format string, args ...any) {
 	timestamp := time.Now().Format("2006-01-02 15:04:05")
 	levelStr := []string{"DEBUG", "INFO", "WARN", "ERROR"}[level]
 	message := fmt.Sprintf(format, args...)
-	
+
 	logLine := fmt.Sprintf("[%s] %s: %s", timestamp, levelStr, message)
 
 	if l.logger != nil {
@@ -90,4 +90,4 @@ func (l *Logger) Warn(format string, args ...any) {
 
 func (l *Logger) Error(format string, args ...any) {
 	l.log(ERROR, format, args...)
-}
+}