Skip to content

Commit 82d7908

Browse files
committed
conftest change to backport, session_factory -> sqlite_session_factory
1 parent e9ae6db commit 82d7908

File tree

2 files changed

+6
-10
lines changed

2 files changed

+6
-10
lines changed

tests/conftest.py

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,24 +18,19 @@
1818

1919

2020
@pytest.fixture
21-
def in_memory_db():
21+
def in_memory_sqlite_db():
2222
engine = create_engine("sqlite:///:memory:")
2323
metadata.create_all(engine)
2424
return engine
2525

2626

2727
@pytest.fixture
28-
def sqlite_session_factory(in_memory_db):
28+
def sqlite_session_factory(in_memory_sqlite_db):
2929
start_mappers()
30-
yield sessionmaker(bind=in_memory_db)
30+
yield sessionmaker(bind=in_memory_sqlite_db)
3131
clear_mappers()
3232

3333

34-
@pytest.fixture
35-
def sqlite_session(sqlite_session_factory):
36-
return sqlite_session_factory()
37-
38-
3934
@retry(stop=stop_after_delay(10))
4035
def wait_for_postgres_to_come_up(engine):
4136
return engine.connect()

tests/integration/test_repository.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@
22
from allocation.domain import model
33

44

5-
def test_get_by_batchref(sqlite_session):
6-
repo = repository.SqlAlchemyRepository(sqlite_session)
5+
def test_get_by_batchref(sqlite_session_factory):
6+
session = sqlite_session_factory()
7+
repo = repository.SqlAlchemyRepository(session)
78
b1 = model.Batch(ref="b1", sku="sku1", qty=100, eta=None)
89
b2 = model.Batch(ref="b2", sku="sku1", qty=100, eta=None)
910
b3 = model.Batch(ref="b3", sku="sku2", qty=100, eta=None)

0 commit comments

Comments
 (0)