tendermint-rpc: remove always-true trinary operator ?:

onError is always console.error now. With the removal of pending(),
this code now doesn't even run at all if the test is skipped.

Author: dynst

packages/tendermint-rpc/src/comet38/comet38client.spec.ts

@@ -878,8 +878,7 @@ function websocketTestSuite(rpcFactory: () => RpcClient, expected: ExpectedValue
 
   describe("With WebsocketClient", () => {
     // don't print out WebSocket errors if marked pending
-    const onError = globalThis.process?.env.TENDERMINT_ENABLED ? console.error : () => 0;
-    const factory = (): WebsocketClient => new WebsocketClient("ws://" + url, onError);
+    const factory = (): WebsocketClient => new WebsocketClient("ws://" + url, console.error);
     defaultTestSuite(factory, expected);
     websocketTestSuite(factory, expected);
   });

packages/tendermint-rpc/src/tendermint34/tendermint34client.spec.ts

@@ -873,8 +873,7 @@ function websocketTestSuite(rpcFactory: () => RpcClient, expected: ExpectedValue
 
   describe("With WebsocketClient", () => {
     // don't print out WebSocket errors if marked pending
-    const onError = globalThis.process?.env.TENDERMINT_ENABLED ? console.error : () => 0;
-    const factory = (): WebsocketClient => new WebsocketClient("ws://" + url, onError);
+    const factory = (): WebsocketClient => new WebsocketClient("ws://" + url, console.error);
     defaultTestSuite(factory, expected);
     websocketTestSuite(factory, expected);
   });

packages/tendermint-rpc/src/tendermint37/tendermint37client.spec.ts

@@ -875,8 +875,7 @@ function websocketTestSuite(rpcFactory: () => RpcClient, expected: ExpectedValue
 
   describe("With WebsocketClient", () => {
     // don't print out WebSocket errors if marked pending
-    const onError = globalThis.process?.env.TENDERMINT_ENABLED ? console.error : () => 0;
-    const factory = (): WebsocketClient => new WebsocketClient("ws://" + url, onError);
+    const factory = (): WebsocketClient => new WebsocketClient("ws://" + url, console.error);
     defaultTestSuite(factory, expected);
     websocketTestSuite(factory, expected);
   });