Skip to content

Commit 4a9846d

Browse files
webmaster128webmaster128
authored
Merge pull request #1836 from dynst/jasmine-xdescribe2
xdescribe() for unconditionally disabled tests
2 parents 1e9b4b4 + a2f7cde commit 4a9846d

File tree

2 files changed

+5
-39
lines changed

2 files changed

+5
-39
lines changed

‎packages/stargate/src/modules/ibc/queries.spec.ts‎

Lines changed: 3 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@ async function makeClientWithIbc(rpcUrl: string): Promise<[QueryClient & IbcExte
1010
return [QueryClient.withExtensions(cometClient, setupIbcExtension), cometClient];
1111
}
1212

13-
describe("IbcExtension", () => {
13+
// We cannot test this easily anymore since the IBC module was removed from simapp
14+
xdescribe("IbcExtension", () => {
1415
describe("channel", () => {
1516
describe("channel", () => {
1617
it("works", async () => {
17-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
1818
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
1919

2020
const response = await client.ibc.channel.channel(ibcTest.portId, ibcTest.channelId);
@@ -28,7 +28,6 @@ describe("IbcExtension", () => {
2828

2929
describe("channels", () => {
3030
it("works", async () => {
31-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
3231
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
3332

3433
const response = await client.ibc.channel.channels();
@@ -42,7 +41,6 @@ describe("IbcExtension", () => {
4241

4342
describe("allChannels", () => {
4443
it("works", async () => {
45-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
4644
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
4745

4846
const response = await client.ibc.channel.allChannels();
@@ -54,7 +52,6 @@ describe("IbcExtension", () => {
5452

5553
describe("connectionChannels", () => {
5654
it("works", async () => {
57-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
5855
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
5956

6057
const response = await client.ibc.channel.connectionChannels(ibcTest.connectionId);
@@ -68,7 +65,6 @@ describe("IbcExtension", () => {
6865

6966
describe("allConnectionChannels", () => {
7067
it("works", async () => {
71-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
7268
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
7369

7470
const response = await client.ibc.channel.allConnectionChannels(ibcTest.connectionId);
@@ -80,7 +76,6 @@ describe("IbcExtension", () => {
8076

8177
describe("clientState", () => {
8278
it("works", async () => {
83-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
8479
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
8580

8681
const response = await client.ibc.channel.clientState(ibcTest.portId, ibcTest.channelId);
@@ -98,7 +93,6 @@ describe("IbcExtension", () => {
9893

9994
describe("consensusState", () => {
10095
xit("works", async () => {
101-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
10296
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
10397

10498
const response = await client.ibc.channel.consensusState(
@@ -120,7 +114,6 @@ describe("IbcExtension", () => {
120114

121115
describe("packetCommitment", () => {
122116
it("works", async () => {
123-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
124117
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
125118

126119
const response = await client.ibc.channel.packetCommitment(
@@ -138,7 +131,6 @@ describe("IbcExtension", () => {
138131

139132
describe("packetCommitments", () => {
140133
it("works", async () => {
141-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
142134
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
143135

144136
const response = await client.ibc.channel.packetCommitments(ibcTest.portId, ibcTest.channelId);
@@ -152,7 +144,6 @@ describe("IbcExtension", () => {
152144

153145
describe("allPacketCommitments", () => {
154146
it("works", async () => {
155-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
156147
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
157148

158149
const response = await client.ibc.channel.allPacketCommitments(ibcTest.portId, ibcTest.channelId);
@@ -164,7 +155,6 @@ describe("IbcExtension", () => {
164155

165156
describe("packetReceipt", () => {
166157
it("works", async () => {
167-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
168158
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
169159

170160
const response = await client.ibc.channel.packetReceipt(ibcTest.portId, ibcTest.channelId, 1);
@@ -175,9 +165,8 @@ describe("IbcExtension", () => {
175165
});
176166

177167
describe("packetAcknowledgement", () => {
168+
// We don't have an acknowledgement for testing at the moment
178169
it("works", async () => {
179-
pending("We don't have an acknowledgement for testing at the moment");
180-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
181170
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
182171

183172
const response = await client.ibc.channel.packetAcknowledgement(
@@ -195,7 +184,6 @@ describe("IbcExtension", () => {
195184

196185
describe("packetAcknowledgements", () => {
197186
it("works", async () => {
198-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
199187
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
200188

201189
const response = await client.ibc.channel.packetAcknowledgements(ibcTest.portId, ibcTest.channelId);
@@ -209,7 +197,6 @@ describe("IbcExtension", () => {
209197

210198
describe("allPacketAcknowledgements", () => {
211199
it("works", async () => {
212-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
213200
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
214201

215202
const response = await client.ibc.channel.allPacketAcknowledgements(
@@ -224,7 +211,6 @@ describe("IbcExtension", () => {
224211

225212
describe("unreceivedPackets", () => {
226213
it("works", async () => {
227-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
228214
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
229215

230216
const response = await client.ibc.channel.unreceivedPackets(
@@ -241,7 +227,6 @@ describe("IbcExtension", () => {
241227

242228
describe("unreceivedAcks", () => {
243229
it("works", async () => {
244-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
245230
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
246231

247232
const response = await client.ibc.channel.unreceivedAcks(
@@ -258,7 +243,6 @@ describe("IbcExtension", () => {
258243

259244
describe("nextSequenceReceive", () => {
260245
it("works", async () => {
261-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
262246
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
263247

264248
const response = await client.ibc.channel.nextSequenceReceive(ibcTest.portId, ibcTest.channelId);
@@ -274,7 +258,6 @@ describe("IbcExtension", () => {
274258
describe("client", () => {
275259
describe("state", () => {
276260
it("works", async () => {
277-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
278261
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
279262

280263
const response = await client.ibc.client.state(ibcTest.clientId);
@@ -289,7 +272,6 @@ describe("IbcExtension", () => {
289272

290273
describe("states", () => {
291274
it("works", async () => {
292-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
293275
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
294276

295277
const response = await client.ibc.client.states();
@@ -310,7 +292,6 @@ describe("IbcExtension", () => {
310292

311293
describe("allStates", () => {
312294
it("works", async () => {
313-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
314295
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
315296

316297
const response = await client.ibc.client.allStates();
@@ -330,7 +311,6 @@ describe("IbcExtension", () => {
330311

331312
describe("consensusState", () => {
332313
it("works", async () => {
333-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
334314
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
335315

336316
const response = await client.ibc.client.consensusState(ibcTest.clientId);
@@ -345,7 +325,6 @@ describe("IbcExtension", () => {
345325

346326
describe("consensusStates", () => {
347327
it("works", async () => {
348-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
349328
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
350329

351330
const response = await client.ibc.client.consensusStates(ibcTest.clientId);
@@ -367,7 +346,6 @@ describe("IbcExtension", () => {
367346

368347
describe("allConsensusStates", () => {
369348
it("works", async () => {
370-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
371349
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
372350

373351
const response = await client.ibc.client.allConsensusStates(ibcTest.clientId);
@@ -389,7 +367,6 @@ describe("IbcExtension", () => {
389367

390368
describe("params", () => {
391369
it("works", async () => {
392-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
393370
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
394371

395372
const response = await client.ibc.client.params();
@@ -403,7 +380,6 @@ describe("IbcExtension", () => {
403380

404381
describe("stateTm", () => {
405382
it("works", async () => {
406-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
407383
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
408384

409385
const response = await client.ibc.client.stateTm(ibcTest.clientId);
@@ -416,7 +392,6 @@ describe("IbcExtension", () => {
416392

417393
describe("statesTm", () => {
418394
it("works", async () => {
419-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
420395
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
421396

422397
const response = await client.ibc.client.statesTm();
@@ -434,7 +409,6 @@ describe("IbcExtension", () => {
434409

435410
describe("allStatesTm", () => {
436411
it("works", async () => {
437-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
438412
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
439413

440414
const response = await client.ibc.client.allStatesTm();
@@ -452,7 +426,6 @@ describe("IbcExtension", () => {
452426

453427
describe("consensusStateTm", () => {
454428
it("works", async () => {
455-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
456429
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
457430

458431
const response = await client.ibc.client.consensusStateTm(ibcTest.clientId);
@@ -467,7 +440,6 @@ describe("IbcExtension", () => {
467440
describe("connection", () => {
468441
describe("connection", () => {
469442
it("works", async () => {
470-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
471443
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
472444

473445
const response = await client.ibc.connection.connection(ibcTest.connectionId);
@@ -481,7 +453,6 @@ describe("IbcExtension", () => {
481453

482454
describe("connections", () => {
483455
it("works", async () => {
484-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
485456
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
486457

487458
const response = await client.ibc.connection.connections();
@@ -495,7 +466,6 @@ describe("IbcExtension", () => {
495466

496467
describe("allConnections", () => {
497468
it("works", async () => {
498-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
499469
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
500470

501471
const response = await client.ibc.connection.allConnections();
@@ -507,7 +477,6 @@ describe("IbcExtension", () => {
507477

508478
describe("clientConnections", () => {
509479
it("works", async () => {
510-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
511480
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
512481

513482
const response = await client.ibc.connection.clientConnections(ibcTest.clientId);
@@ -521,7 +490,6 @@ describe("IbcExtension", () => {
521490

522491
describe("clientState", () => {
523492
it("works", async () => {
524-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
525493
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
526494

527495
const response = await client.ibc.connection.clientState(ibcTest.connectionId);
@@ -539,7 +507,6 @@ describe("IbcExtension", () => {
539507

540508
describe("consensusState", () => {
541509
xit("works", async () => {
542-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
543510
const [client, cometClient] = await makeClientWithIbc(simapp.tendermintUrlHttp);
544511

545512
// TODO: Find valid values

‎packages/stargate/src/signingstargateclient.spec.ts‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -251,9 +251,9 @@ describe("SigningStargateClient", () => {
251251
});
252252
});
253253

254-
describe("sendIbcTokens", () => {
254+
// We cannot test this easily anymore since the IBC module was removed from simapp
255+
xdescribe("sendIbcTokens", () => {
255256
it("works with direct signing", async () => {
256-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
257257
const wallet = await DirectSecp256k1HdWallet.fromMnemonic(faucet.mnemonic);
258258
const client = await SigningStargateClient.connectWithSigner(
259259
simapp.tendermintUrlHttp,
@@ -302,7 +302,6 @@ describe("SigningStargateClient", () => {
302302
});
303303

304304
it("works with Amino JSON signer", async () => {
305-
pending("We cannot test this easily anymore since the IBC module was removed from simapp");
306305
const wallet = await Secp256k1HdWallet.fromMnemonic(faucet.mnemonic);
307306
const client = await SigningStargateClient.connectWithSigner(
308307
simapp.tendermintUrlHttp,

0 commit comments

Comments
 (0)