Merge pull request #1754 from dynst/any-removal-1

remove some any types

Author: webmaster128

packages/amino/src/secp256k1hdwallet.ts

@@ -202,7 +202,9 @@ export class Secp256k1HdWallet implements OfflineAminoSigner {
   ): Promise<Secp256k1HdWallet> {
     const root = JSON.parse(serialization);
     if (!isNonNullObject(root)) throw new Error("Root document is not an object.");
-    const untypedRoot: any = root;
+    // This cast is safe because `root` comes from a valid JSON document and `root` is a non-null object.
+    // I.e. it can only be a JSON object, not an aribitrary JS object.
+    const untypedRoot: Record<string, any> = root;
     switch (untypedRoot.type) {
       case serializationTypeV1: {
         const decryptedBytes = await decrypt(

packages/amino/src/signdoc.ts

@@ -6,7 +6,7 @@ import { Coin } from "./coins";
 
 export interface AminoMsg {
   readonly type: string;
-  readonly value: any;
+  readonly value: Record<string, any>;
 }
 
 export interface StdFee {

packages/amino/src/stdtx.spec.ts

@@ -53,7 +53,7 @@ describe("makeStdTx", () => {
 describe("isStdTx", () => {
   const validTx: StdTx = {
     memo: "memoe",
-    msg: [{ type: "test", value: "Test Value" }],
+    msg: [{ type: "test", value: { test: "Value" } }],
     fee: { amount: [{ denom: "ATOM", amount: "10" }], gas: "100000" },
     signatures: [{ signature: "signature", pub_key: { type: "type", value: "value" } }],
   };

packages/faucet-client/src/faucetclient.ts

@@ -22,15 +22,6 @@ export class FaucetClient {
       denom: denom,
     };
 
-    try {
-      await fetch(this.baseUrl + "/credit", { method: "POST", body: JSON.stringify(body) });
-    } catch (error: any) {
-      if (error.response) {
-        // append response body to error message
-        throw new Error(`${error}; response body: ${JSON.stringify(error.response.data)}`);
-      } else {
-        throw error;
-      }
-    }
+    await fetch(this.baseUrl + "/credit", { method: "POST", body: JSON.stringify(body) });
   }
 }

packages/faucet/src/api/webserver.ts

@@ -58,7 +58,7 @@ export class Webserver {
           }
 
           // context.request.body is set by the bodyParser() plugin
-          const requestBody = (context.request as any).body;
+          const requestBody = context.request.body;
           const creditBody = RequestParser.parseCreditBody(requestBody);
           const { address, denom } = creditBody;
 

packages/stargate/src/modules/gov/aminomessages.ts

@@ -28,7 +28,7 @@ export interface AminoMsgSubmitProposal extends AminoMsg {
      */
     readonly content: {
       readonly type: string;
-      readonly value: any;
+      readonly value: Record<string, any>;
     };
     readonly initial_deposit: readonly Coin[];
     /** Bech32 account address */

packages/stargate/src/stargateclient.ts

@@ -287,7 +287,8 @@ export class StargateClient {
     try {
       const account = await this.forceGetQueryClient().auth.account(searchAddress);
       return account ? this.accountParser(account) : null;
-    } catch (error: any) {
+    } catch (error) {
+      assert(error instanceof Error);
       if (/rpc error: code = NotFound/i.test(error.toString())) {
         return null;
       }
@@ -369,7 +370,8 @@ export class StargateClient {
       delegatedAmount = (
         await this.forceGetQueryClient().staking.delegation(delegatorAddress, validatorAddress)
       ).delegationResponse?.balance;
-    } catch (e: any) {
+    } catch (e) {
+      assert(e instanceof Error);
       if (e.toString().includes("key not found")) {
         // ignore, `delegatedAmount` remains undefined
       } else {

packages/tendermint-rpc/src/rpcclients/http.ts

@@ -1,4 +1,4 @@
-function filterBadStatus(res: any): any {
+function filterBadStatus(res: Response): Response {
   if (res.status >= 400) {
     throw new Error(`Bad status on response: ${res.status}`);
   }
@@ -28,5 +28,5 @@ export async function http(
   };
   return fetch(url, settings)
     .then(filterBadStatus)
-    .then((res: any) => res.json());
+    .then((res) => res.json());
 }

packages/tendermint-rpc/src/rpcclients/rpcclient.ts

@@ -12,7 +12,7 @@ export interface SubscriptionEvent {
   readonly query: string;
   readonly data: {
     readonly type: string;
-    readonly value: any;
+    readonly value: Record<string, any>;
   };
 }
 
@@ -26,7 +26,7 @@ export interface RpcStreamingClient extends RpcClient {
 }
 
 export function instanceOfRpcStreamingClient(client: RpcClient): client is RpcStreamingClient {
-  return typeof (client as any).listen === "function";
+  return "listen" in client && typeof client.listen === "function";
 }
 
 // Helpers for all RPC clients