Merge pull request #1683 from cosmos/address-length128

Let faucet accept addresses up to 128 bytes

Author: webmaster128

CHANGELOG.md

@@ -6,6 +6,13 @@ and this project adheres to
 
 ## [Unreleased]
 
+### Fixed
+
+- @cosmjs/faucet: `isValidAddress` now accepts addresses up to 128 bytes (e.g.
+  for Penumbra). ([#1674])
+
+[#1674]: https://github.com/cosmos/cosmjs/pull/1674
+
 ### Added
 
 - @cosmjs/tendermint-rpc: `Comet38Client` is now used to connect to CometBFT

packages/faucet/src/addresses.spec.ts

@@ -11,6 +11,15 @@ describe("isValidAddress", () => {
     );
   });
 
+  it("accepts a Penumbra compat address", () => {
+    expect(
+      isValidAddress(
+        "penumbracompat11ld2kghffzgwq4597ejpgmnwxa7ju0cndytuxtsjh8qhjyfuwq0rwd5flnw4a3fgclw7m5puh50nskn2c88flhne2hzchnpxru609d5wgmqqvhdf0sy2tktqfcm2p2tmxeuc86n",
+        "penumbracompat1",
+      ),
+    ).toBe(true);
+  });
+
   it("rejects an invalid address", () => {
     expect(isValidAddress("cosmos1fail", "cosmos")).toBe(false);
   });

packages/faucet/src/addresses.ts

@@ -1,12 +1,16 @@
 import { fromBech32 } from "@cosmjs/encoding";
 
+// Penumbra are up to 150 chars. ibc-go has a limit of 2048.
+// See https://github.com/cosmos/cosmjs/pull/1674
+const lengthLimit = 512;
+
 export function isValidAddress(input: string, requiredPrefix: string): boolean {
   try {
-    const { prefix, data } = fromBech32(input);
+    const { prefix, data } = fromBech32(input, lengthLimit);
     if (prefix !== requiredPrefix) {
       return false;
     }
-    return data.length >= 20 && data.length <= 32;
+    return data.length >= 20 && data.length <= 128;
   } catch {
     return false;
   }