Skip to content

Commit 878630c

Browse files
committed
Adapt comments and docs to 0.34 removal
1 parent a11abbb commit 878630c

File tree

9 files changed

+6
-39
lines changed

9 files changed

+6
-39
lines changed

HACKING.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,6 @@ order to avoid conflicts. Here is an overview of the ports used:
115115
| 5555 | httpserver | @cosmjs/tendermint-rpc tests |
116116
| 9090 | simapp gRPC | Manual Stargate debugging |
117117
| 11101 | Standalone CometBFT 1.x RPC | @cosmjs/tendermint-rpc tests |
118-
| 11134 | Standalone Tendermint 0.34 RPC | @cosmjs/tendermint-rpc tests |
119-
| 11135 | Standalone Tendermint 0.35 RPC | @cosmjs/tendermint-rpc tests |
120118
| 11137 | Standalone Tendermint 0.37 RPC | @cosmjs/tendermint-rpc tests |
121119
| 11138 | Standalone CometBFT 0.38 RPC | @cosmjs/tendermint-rpc tests |
122120
| 26658 | simapp Tendermint RPC | Stargate client tests |

packages/cosmwasm-stargate/src/cosmwasmclient.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ export class CosmWasmClient {
9292
/**
9393
* Creates an instance by connecting to the given CometBFT RPC endpoint.
9494
*
95-
* This uses auto-detection to decide between a CometBFT 0.38, Tendermint 0.37 and 0.34 client.
95+
* This uses auto-detection to decide between a CometBFT 1.x, CometBFT 0.38 and Tendermint 0.37 client.
9696
* To set the Comet client explicitly, use `create`.
9797
*/
9898
public static async connect(endpoint: string | HttpEndpoint): Promise<CosmWasmClient> {

packages/cosmwasm-stargate/src/signingcosmwasmclient.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ export class SigningCosmWasmClient extends CosmWasmClient {
208208
/**
209209
* Creates an instance by connecting to the given CometBFT RPC endpoint.
210210
*
211-
* This uses auto-detection to decide between a CometBFT 0.38, Tendermint 0.37 and 0.34 client.
211+
* This uses auto-detection to decide between a CometBFT 1.x, CometBFT 0.38 and Tendermint 0.37 client.
212212
* To set the Comet client explicitly, use `createWithSigner`.
213213
*/
214214
public static async connectWithSigner(

packages/stargate/src/events.ts

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,12 @@
11
import { comet1, comet38, tendermint37 } from "@cosmjs/tendermint-rpc";
22

3-
/**
4-
* An event attribute.
5-
*
6-
* This is the same attribute type as tendermint34.Attribute and tendermint35.EventAttribute
7-
* but `key` and `value` are unified to strings. The conversion
8-
* from bytes to string in the Tendermint 0.34 case should be done by performing
9-
* [lossy] UTF-8 decoding.
10-
*
11-
* [lossy]: https://doc.rust-lang.org/stable/std/string/struct.String.html#method.from_utf8_lossy
12-
*/
3+
/** An event attribute */
134
export interface Attribute {
145
readonly key: string;
156
readonly value: string;
167
}
178

18-
/**
19-
* The same event type as tendermint34.Event and tendermint35.Event
20-
* but attribute keys and values are unified to strings. The conversion
21-
* from bytes to string in the Tendermint 0.34 case should be done by performing
22-
* [lossy] UTF-8 decoding.
23-
*
24-
* [lossy]: https://doc.rust-lang.org/stable/std/string/struct.String.html#method.from_utf8_lossy
25-
*/
9+
/** An event */
2610
export interface Event {
2711
readonly type: string;
2812
readonly attributes: readonly Attribute[];

packages/stargate/src/signingstargateclient.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ export class SigningStargateClient extends StargateClient {
115115
/**
116116
* Creates an instance by connecting to the given CometBFT RPC endpoint.
117117
*
118-
* This uses auto-detection to decide between a CometBFT 0.38, Tendermint 0.37 and 0.34 client.
118+
* This uses auto-detection to decide between a CometBFT 1.x, CometBFT 0.38 and Tendermint 0.37 client.
119119
* To set the Comet client explicitly, use `createWithSigner`.
120120
*/
121121
public static async connectWithSigner(

packages/stargate/src/stargateclient.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ export class StargateClient {
213213
/**
214214
* Creates an instance by connecting to the given CometBFT RPC endpoint.
215215
*
216-
* This uses auto-detection to decide between a CometBFT 0.38, Tendermint 0.37 and 0.34 client.
216+
* This uses auto-detection to decide between a CometBFT 1.x, CometBFT 0.38 and Tendermint 0.37 client.
217217
* To set the Comet client explicitly, use `create`.
218218
*/
219219
public static async connect(

packages/tendermint-rpc/src/comet1/comet1client.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,9 +99,6 @@ export class Comet1Client {
9999

100100
// this should paginate through all blockSearch options to ensure it returns all results.
101101
// starts with page 1 or whatever was provided (eg. to start on page 7)
102-
//
103-
// NOTE
104-
// This method will error on any node that is running a Tendermint version lower than 0.34.9.
105102
public async blockSearchAll(params: requests.BlockSearchParams): Promise<responses.BlockSearchResponse> {
106103
let page = params.page || 1;
107104
const blocks: responses.BlockResponse[] = [];

packages/tendermint-rpc/src/comet38/comet38client.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,6 @@ export class Comet38Client {
8585
/**
8686
* Search for events that are in a block.
8787
*
88-
* NOTE
89-
* This method will error on any node that is running a Tendermint version lower than 0.34.9.
90-
*
9188
* @see https://docs.tendermint.com/master/rpc/#/Info/block_search
9289
*/
9390
public async blockSearch(params: requests.BlockSearchParams): Promise<responses.BlockSearchResponse> {
@@ -102,9 +99,6 @@ export class Comet38Client {
10299

103100
// this should paginate through all blockSearch options to ensure it returns all results.
104101
// starts with page 1 or whatever was provided (eg. to start on page 7)
105-
//
106-
// NOTE
107-
// This method will error on any node that is running a Tendermint version lower than 0.34.9.
108102
public async blockSearchAll(params: requests.BlockSearchParams): Promise<responses.BlockSearchResponse> {
109103
let page = params.page || 1;
110104
const blocks: responses.BlockResponse[] = [];

packages/tendermint-rpc/src/tendermint37/tendermint37client.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,6 @@ export class Tendermint37Client {
8282
/**
8383
* Search for events that are in a block.
8484
*
85-
* NOTE
86-
* This method will error on any node that is running a Tendermint version lower than 0.34.9.
87-
*
8885
* @see https://docs.tendermint.com/master/rpc/#/Info/block_search
8986
*/
9087
public async blockSearch(params: requests.BlockSearchParams): Promise<responses.BlockSearchResponse> {
@@ -99,9 +96,6 @@ export class Tendermint37Client {
9996

10097
// this should paginate through all blockSearch options to ensure it returns all results.
10198
// starts with page 1 or whatever was provided (eg. to start on page 7)
102-
//
103-
// NOTE
104-
// This method will error on any node that is running a Tendermint version lower than 0.34.9.
10599
public async blockSearchAll(params: requests.BlockSearchParams): Promise<responses.BlockSearchResponse> {
106100
let page = params.page || 1;
107101
const blocks: responses.BlockResponse[] = [];

0 commit comments

Comments
 (0)