Skip to content

Commit af47f4f

Browse files
authored
Merge pull request #1716 from cosmos/drop-node18
Drop node18
2 parents c376946 + 2031cbf commit af47f4f

30 files changed

+263
-65
lines changed

.circleci/config.yml

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ workflows:
2424
jobs:
2525
build:
2626
docker:
27-
- image: cimg/node:18.20
27+
- image: cimg/node:22.17
2828
steps:
2929
- run:
3030
name: Install Git Large File Storage (LFS)
@@ -99,12 +99,9 @@ jobs:
9999
mkdir -p ~/.local/share/Trash && mv "$NVM_DIR" ~/.npm ~/.local/share/Trash
100100
- run:
101101
name: Install nodejs
102-
# In the current image, `sudo apt install nodejs` requires `sudo apt update` which is too slow.
103-
# Follow instructions of https://deb.nodesource.com/ except the last step. Then run
104-
# `apt download --print-uris nodejs` to get a download URL.
105102
command: |
106-
wget -O "$HOME/nodejs.deb" https://deb.nodesource.com/node_18.x/pool/main/n/nodejs/nodejs_18.17.1-1nodesource1_amd64.deb
107-
sudo dpkg -i "$HOME/nodejs.deb"
103+
curl -fsSL https://deb.nodesource.com/setup_22.x | sudo bash -
104+
sudo apt-get install -y nodejs
108105
- run:
109106
name: Install yarn
110107
command: |
@@ -211,12 +208,9 @@ jobs:
211208
mkdir -p ~/.local/share/Trash && mv "$NVM_DIR" ~/.npm ~/.local/share/Trash
212209
- run:
213210
name: Install nodejs
214-
# In the current image, `sudo apt install nodejs` requires `sudo apt update` which is too slow.
215-
# Follow instructions of https://deb.nodesource.com/ except the last step. Then run
216-
# `apt download --print-uris nodejs` to get a download URL.
217211
command: |
218-
wget -O "$HOME/nodejs.deb" https://deb.nodesource.com/node_18.x/pool/main/n/nodejs/nodejs_18.17.1-1nodesource1_amd64.deb
219-
sudo dpkg -i "$HOME/nodejs.deb"
212+
curl -fsSL https://deb.nodesource.com/setup_22.x | sudo bash -
213+
sudo apt-get install -y nodejs
220214
- run:
221215
name: Install yarn
222216
command: |
@@ -320,12 +314,9 @@ jobs:
320314
mkdir -p ~/.local/share/Trash && mv "$NVM_DIR" ~/.npm ~/.local/share/Trash
321315
- run:
322316
name: Install nodejs
323-
# In the current image, `sudo apt install nodejs` requires `sudo apt update` which is too slow.
324-
# Follow instructions of https://deb.nodesource.com/ except the last step. Then run
325-
# `apt download --print-uris nodejs` to get a download URL.
326317
command: |
327-
wget -O "$HOME/nodejs.deb" https://deb.nodesource.com/node_18.x/pool/main/n/nodejs/nodejs_18.17.1-1nodesource1_amd64.deb
328-
sudo dpkg -i "$HOME/nodejs.deb"
318+
curl -fsSL https://deb.nodesource.com/setup_22.x | sudo bash -
319+
sudo apt-get install -y nodejs
329320
- run:
330321
name: Install yarn
331322
command: |

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
test:
1010
strategy:
1111
matrix:
12-
node-version: ["18", "20", "22", "24"]
12+
node-version: ["20", "22", "24"]
1313
runs-on: ubuntu-latest
1414
steps:
1515
- uses: actions/checkout@v4

.pnp.cjs

Lines changed: 108 additions & 17 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
version https://git-lfs.github.com/spec/v1
2+
oid sha256:11bf20dc56aebd5858fb253ae3b904a6d0681194fffa0b589be77352bf2fbe1a
3+
size 21534
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
version https://git-lfs.github.com/spec/v1
2+
oid sha256:597691b3c172e4691c621a2cb4eeb0d83f2690d787e6e16619431e599f85c3a1
3+
size 48705
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
version https://git-lfs.github.com/spec/v1
2+
oid sha256:3ff46589aafe0cbb9786a910df1bbf28897066a0d824581da245bc53b825b3ed
3+
size 18012
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
version https://git-lfs.github.com/spec/v1
2+
oid sha256:2604bfc282ea0e9a0e187b39e4268ebadfb083334f506cc30805f3500557564c
3+
size 75920
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
version https://git-lfs.github.com/spec/v1
2+
oid sha256:649d0e557e75c9401aba09e91af340737b9f03b609530fb15502e3db0fabe8be
3+
size 486077
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
version https://git-lfs.github.com/spec/v1
2+
oid sha256:69639c396047d1d6d29d5b809a15914a7a0199809e861ddd1abb6dd40f3afb80
3+
size 290550
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
version https://git-lfs.github.com/spec/v1
2+
oid sha256:e7ffb49363008ace7f268aeb5b78baba11fc482ee4532613722e847b97f416b4
3+
size 823451

0 commit comments

Comments
 (0)