Skip to content

Commit e3243ae

Browse files
committed
typeof number not instanceof Number wrapper class
1 parent 8ad0682 commit e3243ae

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

packages/tendermint-rpc/src/comet1/comet1client.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,7 @@ function defaultTestSuite(rpcFactory: () => RpcClient, expected: ExpectedValues)
387387
const meta = blockchain.blockMetas[0];
388388

389389
expect(meta.blockId).toEqual(jasmine.objectContaining({}));
390-
expect(meta.blockSize).toBeInstanceOf(Number);
390+
expect(typeof meta.blockSize).toBe("number");
391391
expect(meta.header).toEqual(
392392
jasmine.objectContaining({
393393
version: {
@@ -397,7 +397,7 @@ function defaultTestSuite(rpcFactory: () => RpcClient, expected: ExpectedValues)
397397
chainId: jasmine.stringMatching(expected.chainId),
398398
}),
399399
);
400-
expect(meta.numTxs).toBeInstanceOf(Number);
400+
expect(typeof meta.numTxs).toBe("number");
401401

402402
client.disconnect();
403403
});

packages/tendermint-rpc/src/comet38/comet38client.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,7 @@ function defaultTestSuite(rpcFactory: () => RpcClient, expected: ExpectedValues)
376376
const meta = blockchain.blockMetas[0];
377377

378378
expect(meta.blockId).toEqual(jasmine.objectContaining({}));
379-
expect(meta.blockSize).toBeInstanceOf(Number);
379+
expect(typeof meta.blockSize).toBe("number");
380380
expect(meta.header).toEqual(
381381
jasmine.objectContaining({
382382
version: {
@@ -386,7 +386,7 @@ function defaultTestSuite(rpcFactory: () => RpcClient, expected: ExpectedValues)
386386
chainId: jasmine.stringMatching(expected.chainId),
387387
}),
388388
);
389-
expect(meta.numTxs).toBeInstanceOf(Number);
389+
expect(typeof meta.numTxs).toBe("number");
390390

391391
client.disconnect();
392392
});

packages/tendermint-rpc/src/tendermint34/tendermint34client.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,7 @@ function defaultTestSuite(rpcFactory: () => RpcClient, expected: ExpectedValues)
383383
const meta = blockchain.blockMetas[0];
384384

385385
expect(meta.blockId).toEqual(jasmine.objectContaining({}));
386-
expect(meta.blockSize).toBeInstanceOf(Number);
386+
expect(typeof meta.blockSize).toBe("number");
387387
expect(meta.header).toEqual(
388388
jasmine.objectContaining({
389389
version: {
@@ -393,7 +393,7 @@ function defaultTestSuite(rpcFactory: () => RpcClient, expected: ExpectedValues)
393393
chainId: jasmine.stringMatching(expected.chainId),
394394
}),
395395
);
396-
expect(meta.numTxs).toBeInstanceOf(Number);
396+
expect(typeof meta.numTxs).toBe("number");
397397

398398
client.disconnect();
399399
});

packages/tendermint-rpc/src/tendermint37/tendermint37client.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,7 @@ function defaultTestSuite(rpcFactory: () => RpcClient, expected: ExpectedValues)
377377
const meta = blockchain.blockMetas[0];
378378

379379
expect(meta.blockId).toEqual(jasmine.objectContaining({}));
380-
expect(meta.blockSize).toBeInstanceOf(Number);
380+
expect(typeof meta.blockSize).toBe("number");
381381
expect(meta.header).toEqual(
382382
jasmine.objectContaining({
383383
version: {
@@ -387,7 +387,7 @@ function defaultTestSuite(rpcFactory: () => RpcClient, expected: ExpectedValues)
387387
chainId: jasmine.stringMatching(expected.chainId),
388388
}),
389389
);
390-
expect(meta.numTxs).toBeInstanceOf(Number);
390+
expect(typeof meta.numTxs).toBe("number");
391391

392392
client.disconnect();
393393
});

0 commit comments

Comments
 (0)