Merge pull request #1920 from cosmos/simapp53

Add simapp testing for Cosmos SDK 0.53

Author: webmaster128

.github/workflows/test.yml

@@ -105,7 +105,7 @@ jobs:
   test-backends:
     strategy:
       matrix:
-        simapp: ["simapp47", "simapp50"]
+        simapp: ["simapp47", "simapp50", "simapp53"]
     runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v6
@@ -150,4 +150,5 @@ jobs:
         run: |
           [ "${{ matrix.simapp }}" = "simapp47" ] && export SIMAPP47_ENABLED=1 SLOW_SIMAPP47_ENABLED=1
           [ "${{ matrix.simapp }}" = "simapp50" ] && export SIMAPP50_ENABLED=1 SLOW_SIMAPP50_ENABLED=1
+          [ "${{ matrix.simapp }}" = "simapp53" ] && export SIMAPP53_ENABLED=1 SLOW_SIMAPP53_ENABLED=1
           yarn run test

packages/faucet/src/testutils.ts

@@ -1,3 +1,5 @@
 export const simappEnabled = !!(
-  globalThis.process?.env.SIMAPP47_ENABLED || globalThis.process?.env.SIMAPP50_ENABLED
+  globalThis.process?.env.SIMAPP47_ENABLED ||
+  globalThis.process?.env.SIMAPP50_ENABLED ||
+  globalThis.process?.env.SIMAPP53_ENABLED
 );

packages/ledger-amino/src/testutils.ts

@@ -11,7 +11,9 @@ export const faucet = {
 export const ledgerEnabled: boolean = !!globalThis.process?.env.LEDGER_ENABLED;
 
 export const simappEnabled: boolean = !!(
-  globalThis.process?.env.SIMAPP47_ENABLED || globalThis.process?.env.SIMAPP50_ENABLED
+  globalThis.process?.env.SIMAPP47_ENABLED ||
+  globalThis.process?.env.SIMAPP50_ENABLED ||
+  globalThis.process?.env.SIMAPP53_ENABLED
 );
 
 export const simapp = {

packages/stargate/src/modules/distribution/queries.spec.ts

@@ -6,7 +6,14 @@ import { MsgDelegate } from "cosmjs-types/cosmos/staking/v1beta1/tx";
 import { QueryClient } from "../../queryclient";
 import { SigningStargateClient } from "../../signingstargateclient";
 import { assertIsDeliverTxSuccess } from "../../stargateclient";
-import { defaultSigningClientOptions, faucet, simapp, simappEnabled, validator } from "../../testutils";
+import {
+  defaultSigningClientOptions,
+  externalCommunityPool,
+  faucet,
+  simapp,
+  simappEnabled,
+  validator,
+} from "../../testutils";
 import { MsgDelegateEncodeObject } from "../";
 import { DistributionExtension, setupDistributionExtension } from "./queries";
 
@@ -51,9 +58,15 @@ async function makeClientWithDistribution(
     it("works", async () => {
       const [client, cometClient] = await makeClientWithDistribution(simapp.tendermintUrlHttp);
 
-      const response = await client.distribution.communityPool();
-      expect(response.pool).toBeDefined();
-      expect(response.pool).not.toBeNull();
+      if (externalCommunityPool) {
+        await expectAsync(client.distribution.communityPool()).toBeRejectedWithError(
+          /external community pool is enabled - use the CommunityPool query exposed by the external community pool/i,
+        );
+      } else {
+        const response = await client.distribution.communityPool();
+        expect(response.pool).toBeDefined();
+        expect(response.pool).not.toBeNull();
+      }
 
       cometClient.disconnect();
     });

packages/stargate/src/signingstargateclient.spec.ts

@@ -43,7 +43,7 @@ import {
   ModifyingDirectSecp256k1HdWallet,
   ModifyingSecp256k1HdWallet,
   simapp,
-  simapp50Enabled,
+  simapp47Enabled,
   simappEnabled,
   validator,
 } from "./testutils";
@@ -118,10 +118,10 @@ import {
       );
       assertIsDeliverTxSuccess(result);
 
-      if (simapp50Enabled) {
-        expect(result.rawLog).toEqual(""); // empty now (https://github.com/cosmos/cosmos-sdk/pull/15845)
-      } else {
+      if (simapp47Enabled) {
         expect(result.rawLog).toBeTruthy();
+      } else {
+        expect(result.rawLog).toEqual(""); // empty for 0.50+ (https://github.com/cosmos/cosmos-sdk/pull/15845)
       }
       expect(result.events.length).toBeGreaterThanOrEqual(1);
 
@@ -159,10 +159,10 @@ import {
       );
       assertIsDeliverTxSuccess(result);
 
-      if (simapp50Enabled) {
-        expect(result.rawLog).toEqual(""); // empty now (https://github.com/cosmos/cosmos-sdk/pull/15845)
-      } else {
+      if (simapp47Enabled) {
         expect(result.rawLog).toBeTruthy();
+      } else {
+        expect(result.rawLog).toEqual(""); // empty for 0.50+ (https://github.com/cosmos/cosmos-sdk/pull/15845)
       }
       expect(result.events.length).toBeGreaterThanOrEqual(1);
 

packages/stargate/src/stargateclient.spec.ts

@@ -28,7 +28,6 @@ import {
   nonExistentAddress,
   simapp,
   simapp47Enabled,
-  simapp50Enabled,
   simappEnabled,
   slowSimapp,
   slowSimappEnabled,
@@ -377,10 +376,10 @@ describe("isDeliverTxSuccess", () => {
 
       const { gasUsed, rawLog, transactionHash } = txResult;
       expect(gasUsed).toBeGreaterThan(0);
-      if (simapp50Enabled) {
-        expect(rawLog).toEqual(""); // empty now (https://github.com/cosmos/cosmos-sdk/pull/15845)
-      } else {
+      if (simapp47Enabled) {
         expect(rawLog).toMatch(/{"key":"amount","value":"1234567ucosm"}/);
+      } else {
+        expect(rawLog).toEqual(""); // empty for 0.50+ (https://github.com/cosmos/cosmos-sdk/pull/15845)
       }
       expect(transactionHash).toMatch(/^[0-9A-F]{64}$/);
 
@@ -453,11 +452,11 @@ describe("isDeliverTxSuccess", () => {
             : // New error code for SDK 0.50+
               /Broadcasting transaction failed with code 4/i,
         );
-        if (simapp50Enabled) {
+        if (simapp47Enabled) {
+          expect(error.code).toEqual(7);
+        } else {
           // New error code for SDK 0.50+
           expect(error.code).toEqual(4);
-        } else {
-          expect(error.code).toEqual(7);
         }
         expect(error.codespace).toEqual("sdk");
       }

packages/stargate/src/testutils.ts

@@ -17,10 +17,16 @@ import { SigningStargateClientOptions } from "./signingstargateclient";
 
 export const simapp47Enabled: boolean = !!globalThis.process?.env.SIMAPP47_ENABLED;
 export const simapp50Enabled: boolean = !!globalThis.process?.env.SIMAPP50_ENABLED;
-export const simappEnabled: boolean = simapp47Enabled || simapp50Enabled;
+export const simapp53Enabled: boolean = !!globalThis.process?.env.SIMAPP53_ENABLED;
+export const simappEnabled: boolean = simapp47Enabled || simapp50Enabled || simapp53Enabled;
 
 export const slowSimappEnabled: boolean =
-  !!globalThis.process?.env.SLOW_SIMAPP47_ENABLED || !!globalThis.process?.env.SLOW_SIMAPP50_ENABLED;
+  !!globalThis.process?.env.SLOW_SIMAPP47_ENABLED ||
+  !!globalThis.process?.env.SLOW_SIMAPP50_ENABLED ||
+  !!globalThis.process?.env.SLOW_SIMAPP53_ENABLED;
+
+// Starting with Cosmos SDK 0.53, an external community pool is used which causes some distribution queries to fail
+export const externalCommunityPool = !simapp47Enabled && !simapp50Enabled;
 
 export function makeRandomAddressBytes(): Uint8Array<ArrayBuffer> {
   return Random.getBytes(20);

packages/stargate/webpack.web.config.cjs

@@ -21,6 +21,8 @@ module.exports = [
         SLOW_SIMAPP47_ENABLED: "",
         SIMAPP50_ENABLED: "",
         SLOW_SIMAPP50_ENABLED: "",
+        SIMAPP53_ENABLED: "",
+        SLOW_SIMAPP53_ENABLED: "",
       }),
     ],
     resolve: {

scripts/simapp53/README.md

@@ -0,0 +1,71 @@
+# Local Simd development network
+
+## Starting the blockchain
+
+Run the following:
+
+```
+cd scripts/simapp53
+./start.sh
+```
+
+## Preset accounts
+
+1. **Faucet**\
+   economy stock theory fatal elder harbor betray wasp final emotion task
+   crumble siren bottom lizard educate guess current outdoor pair theory focus
+   wife stone\
+   Address 0: cosmos1pkptre7fdkl6gfrzlesjjvhxhlc3r4gmmk8rs6\
+   Address 1: cosmos10dyr9899g6t0pelew4nvf4j5c3jcgv0r73qga5\
+   Address 2: cosmos1xy4yqngt0nlkdcenxymg8tenrghmek4nmqm28k\
+   Address 3: cosmos142u9fgcjdlycfcez3lw8x6x5h7rfjlnfhpw2lx\
+   Address 4: cosmos1hsm76p4ahyhl5yh3ve9ur49r5kemhp2r0dcjvx\
+   Pubkey 0: A08EGB7ro1ORuFhjOnZcSgwYlpe0DSFjVNUIkNNQxwKQ\
+   Pubkey 1: AiDosfIbBi54XJ1QjCeApumcy/FjdtF+YhywPf3DKTx7\
+   Pubkey 2: AzQg33JZqH7vSsm09esZY5bZvmzYwE/SY78cA0iLxpD7\
+   Pubkey 3: A3gOAlB6aiRTCPvWMQg2+ZbGYNsLd8qlvV28m8p2UhY2\
+   Pubkey 4: Aum2063ub/ErUnIUB36sK55LktGUStgcbSiaAnL1wadu
+2. **Alice**: Test account for the cosmwasm package that can run in parallel
+   with faucet without sequence conflicts\
+   enlist hip relief stomach skate base shallow young switch frequent cry park\
+   Address 0: cosmos14qemq0vw6y3gc3u3e0aty2e764u4gs5le3hada\
+   Address 1: cosmos1hhg2rlu9jscacku2wwckws7932qqqu8x3gfgw0\
+   Address 2: cosmos1xv9tklw7d82sezh9haa573wufgy59vmwe6xxe5\
+   Address 3: cosmos17yg9mssjenmc3jkqth6ulcwj9cxujrxxzezwta\
+   Address 4: cosmos1f7j7ryulwjfe9ljplvhtcaxa6wqgula3etktce\
+   Pubkey 0: A9cXhWb8ZpqCzkA8dQCPV29KdeRLV3rUYxrkHudLbQtS\
+   Pubkey 1: A4XluzvcUx0ViLF0DjYW5/noArGwpltDstoUUZo+g1b0\
+   Pubkey 2: A5TKr1NKc/MKRJ7+EHDD9PlzmGaPD/di/6hzZyBwxoy5\
+   Pubkey 3: A/HSABDUqMB2qDy+PA7fiuuuA+hfrco2VwwiThMiTzUx\
+   Pubkey 4: A7usTiqgqfxL/WKhoephDUSCHBQlLagtwI/qTmEteTRM
+3. **Bob**: Test account (unused for now)\
+   remain fragile remove stamp quiz bus country dress critic mammal office need\
+   Address 0: cosmos1lvrwcvrqlc5ktzp2c4t22xgkx29q3y83lktgzl\
+   Address 1: cosmos1vkv9sfwaak76weyamqx0flmng2vuquxqcuqukh\
+   Address 2: cosmos106jwym4s9aujcmes26myzzwqsccw09sdm0v5au\
+   Address 3: cosmos1c7wpeen2uv8thayf7g8q2rgpm29clj0dgrdtzw\
+   Address 4: cosmos1mjxpv9ft30wer7ma7kwfxhm42l379xutplrdk6\
+   Pubkey 0: A0d/GxY+UALE+miWJP0qyq4/EayG1G6tsg24v+cbD6By\
+   Pubkey 1: Agqd6njsVEQD1CR+F2aqEb8hil5NXZ06mjKgetaNC12t\
+   Pubkey 2: A6e9ElvKaM0DKWh1bIdK3bgB14dyEDgIXYMA0Lbs1GoQ\
+   Pubkey 3: AkAK5PQaucieWMb0+tTRY01feYI+upRnoNK556eD0Ibb\
+   Pubkey 4: A5HMVEAJsupdQWItbZv5Z1xZifDixQi6tjU/hJpZY1bF
+4. **Unused**: for testing account state; this account never changes balances or
+   sequences\
+   oyster design unusual machine spread century engine gravity focus cave carry
+   slot\
+   ArkCaFUJ/IH+vKBmNRCdUVl3mCAhbopk9jjW4Ko4OfRQ\
+   cosmos1cjsxept9rkggzxztslae9ndgpdyt2408lk850u
+5. **Guest**: account for manual testing\
+   degree tackle suggest window test behind mesh extra cover prepare oak script\
+   Am/+YV0LaeqQPu7BDJuDHV7J8y68ptkGs10YS+9s71Nq\
+   cosmos17d0jcz59jf68g52vq38tuuncmwwjk42u6mcxej
+
+### Multisig accounts
+
+1. 1/5 threshold multisig of the first 5 faucet accounts\
+   cosmos1v75snhly7wfndk83ud4daygh397vcmkta8rlzq
+2. 2/5 threshold multisig of the first 5 faucet accounts\
+   cosmos1h90ml36rcu7yegwduzgzderj2jmq49hcpfclw9
+3. 3/5 threshold multisig of the first 5 faucet accounts\
+   cosmos1d2mg2euvus3tu2tprfwrfzeal4xu7kygugjxjc

scripts/simapp53/env

@@ -0,0 +1,5 @@
+# Choose from https://github.com/cosmos/cosmos-sdk/pkgs/container/simapp
+REPOSITORY="ghcr.io/cosmos/simapp"
+VERSION="0.53.4"
+CONTAINER_NAME="simapp"
+CONTAINER_NAME_SLOW="simapp-slow"