You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix(x/staking): validate bond_denom exists before updating params
Addresses issue #25724 by validating that the bond_denom has a non-zero
supply before allowing MsgUpdateParams to update the staking parameters.
Changes based on PR review feedback:
- Use sdkerrors.ErrInvalidRequest instead of custom error
- Remove brittle mock-based test case
- Add comprehensive integration test using real keepers
The validation checks bankKeeper.GetSupply() to ensure the denom exists
with non-zero supply, preventing invalid denom configuration.
`CheckTxHandler` allows users to extend the logic of `CheckTx`. `CheckTxHandler` is called by passing context and the transaction bytes received through ABCI. It is required that the handler returns deterministic results given the same transaction bytes.
24
-
25
-
:::note
26
-
we return the raw decoded transaction here to avoid decoding it twice.
27
-
:::
23
+
`CheckTxHandler` allows applications to extend the logic of `CheckTx`. It is invoked with the ABCI request and a `RunTx` function that executes the standard `CheckTx` pipeline (ante handlers, gas accounting and mempool interaction). The implementation of `CheckTxHandler` MUST be deterministic for a given `RequestCheckTx`.
Setting a custom `CheckTxHandler` is optional. It can be done from your app.go file:
29
+
The provided `RunTx` function does not override ante handlers and does not allow changing the execution mode; it simply runs the transaction through the normal `CheckTx` path and returns the result that can be used to construct a `ResponseCheckTx`.
30
+
31
+
Setting a custom `CheckTxHandler` is optional. It can be done from your `app.go` file by setting the handler on `BaseApp`:
When `RequestCheckTx.Type` is `abci.CheckTxType_New`, the transaction is evaluated for admission into the mempool; when it is `abci.CheckTxType_Recheck`, the existing mempool transaction is re-evaluated and may be removed if it no longer passes validation. Successful `CheckTx` executions update an internal CheckTx state, which is reset when a block is committed.
0 commit comments