fix: event emission in erc20 precompile (#774)

aljo242 · web-flow · commit a3a2a068a9f7 · 2025-10-28T19:35:54.000Z
* fix

* fix
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,6 +15,7 @@
 - [\#748](https://github.com/cosmos/evm/pull/748) Fix DynamicFeeChecker in Cosmos ante handler to respect NoBaseFee feemarkets' parameter.
 - [\#756](https://github.com/cosmos/evm/pull/756) Fix error message typo in NewMsgCancelProposal.
 - [\#772](https://github.com/cosmos/evm/pull/772) Avoid panic on close if evm mempool not used.
+- [\#774](https://github.com/cosmos/evm/pull/774) Emit proper allowance amount in erc20 event.
 
 ## v0.5.0
 
diff --git a/precompiles/erc20/tx.go b/precompiles/erc20/tx.go
@@ -87,14 +87,12 @@ func (p *Precompile) transfer(
 	newAllowance := big.NewInt(0)
 
 	if isTransferFrom {
-		spenderAddr := contract.Caller()
-
 		prevAllowance, err := p.erc20Keeper.GetAllowance(ctx, p.Address(), from, spenderAddr)
 		if err != nil {
 			return nil, ConvertErrToERC20Error(err)
 		}
 
-		newAllowance := new(big.Int).Sub(prevAllowance, amount)
+		newAllowance = new(big.Int).Sub(prevAllowance, amount)
 		if newAllowance.Sign() < 0 {
 			return nil, ErrInsufficientAllowance
 		}

Original file line number	Diff line number	Diff line change
`@@ -87,14 +87,12 @@ func (p *Precompile) transfer(`
`87`	`87`	`newAllowance := big.NewInt(0)`
`88`	`88`
`89`	`89`	`if isTransferFrom {`
`90`		`- spenderAddr := contract.Caller()`
`91`		`-`
`92`	`90`	`prevAllowance, err := p.erc20Keeper.GetAllowance(ctx, p.Address(), from, spenderAddr)`
`93`	`91`	`if err != nil {`
`94`	`92`	`return nil, ConvertErrToERC20Error(err)`
`95`	`93`	`}`
`96`	`94`
`97`		`- newAllowance := new(big.Int).Sub(prevAllowance, amount)`
	`95`	`+ newAllowance = new(big.Int).Sub(prevAllowance, amount)`
`98`	`96`	`if newAllowance.Sign() < 0 {`
`99`	`97`	`return nil, ErrInsufficientAllowance`
`100`	`98`	`}`