Skip to content

Conversation

@cloudgray
Copy link
Contributor

Description

Closes: #XXXX

Inject block-stm-enabled app into existing tests

This PR should be merged after #845 is merged


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

@cloudgray cloudgray mentioned this pull request Dec 8, 2025
3 tasks
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.50%. Comparing base (d97c9e5) to head (d92afb5).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #879      +/-   ##
==========================================
- Coverage   65.20%   62.50%   -2.71%     
==========================================
  Files         317      317              
  Lines       21614    21615       +1     
==========================================
- Hits        14094    13510     -584     
- Misses       6360     6898     +538     
- Partials     1160     1207      +47     
Files with missing lines Coverage Δ
encoding/config.go 100.00% <100.00%> (ø)
x/vm/keeper/keeper.go 82.18% <100.00%> (+0.41%) ⬆️

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cloudgray cloudgray marked this pull request as ready for review December 8, 2025 10:58
@cloudgray cloudgray self-assigned this Dec 8, 2025
@cloudgray cloudgray requested a review from vladjdk December 8, 2025 10:58
test-unit-cover: TEST_PACKAGES=$(PACKAGES_UNIT)
test-unit-cover: run-tests
@echo "🔍 Running evm (root) coverage..."
@go test -race -tags=test $(COMMON_COVER_ARGS) -coverpkg=$(COVERPKG_ALL) -coverprofile=coverage.txt ./...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add this back?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aljo242
I branched this PR off of PR #825, and the removal of the -race flag was a change introduced in PR #825.
We may need confirmation from @vladjdk, the author of PR #825.

@vladjdk
Was this change intentional?
As far as I know, enabling the -race option allows data race detection, but it also increases the build size as well as execution time and memory usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants