refactor: using slices.Contains to simplify the code

dashangcun · dashangcun · commit 45bf7517d1db · 2025-01-14T10:13:23.000+08:00
Signed-off-by: dashangcun &lt;907225865@qq.com&gt;
diff --git a/modules/apps/27-interchain-accounts/host/types/keys.go b/modules/apps/27-interchain-accounts/host/types/keys.go
@@ -2,6 +2,7 @@ package types
 
 import (
 	sdk "github.com/cosmos/cosmos-sdk/types"
+	slices
 )
 
 const (
@@ -25,11 +26,5 @@ func ContainsMsgType(allowMsgs []string, msg sdk.Msg) bool {
 		return true
 	}
 
-	for _, v := range allowMsgs {
-		if v == sdk.MsgTypeURL(msg) {
-			return true
-		}
-	}
-
-	return false
+	return slices.Contains(allowMsgs, sdk.MsgTypeURL(msg))
 }

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@ package types`
`2`	`2`
`3`	`3`	`import (`
`4`	`4`	`sdk "github.com/cosmos/cosmos-sdk/types"`
	`5`	`+ slices`
`5`	`6`	`)`
`6`	`7`
`7`	`8`	`const (`
`@@ -25,11 +26,5 @@ func ContainsMsgType(allowMsgs []string, msg sdk.Msg) bool {`
`25`	`26`	`return true`
`26`	`27`	`}`
`27`	`28`
`28`		`- for _, v := range allowMsgs {`
`29`		`- if v == sdk.MsgTypeURL(msg) {`
`30`		`- return true`
`31`		`- }`
`32`		`- }`
`33`		`-`
`34`		`- return false`
	`29`	`+ return slices.Contains(allowMsgs, sdk.MsgTypeURL(msg))`
`35`	`30`	`}`