chore: update callbacks release branch (#8056)

* chore: update sonarqube gh action (#7985) (#7988)

(cherry picked from commit fcb6809)

Co-authored-by: Gjermund Garaba <gjermund@garaba.net>

* test: fix ica compatibility tests (#7976) (#7994)

* test: fix ica compatibility tests

* lint

* fix event search

* lint

(cherry picked from commit 22efa6c)

Co-authored-by: Gjermund Garaba <gjermund@garaba.net>

* docs: document ICS23 MerklePath (#7993) (#7995)

* proto docs

* more go docs

(cherry picked from commit 0e8a6c9)

Co-authored-by: Aditya <14364734+AdityaSripal@users.noreply.github.com>

* MsgTransfer For Eureka (#7957) (#8001)

* initial progress

* progress

* initial build and existing tests pass

* testing

* documentation for tests

* refactor

* fix regression

* Update modules/apps/transfer/types/packet.go

Co-authored-by: Gjermund Garaba <gjermund@garaba.net>

* remove clientKeeperv2 necessity in code

* remove clientkeeperv2 in transfer keeper

---------

Co-authored-by: Gjermund Garaba <gjermund@garaba.net>
(cherry picked from commit 9f677ba)

Co-authored-by: Aditya <14364734+AdityaSripal@users.noreply.github.com>

* Remove 29-fee (#8000) (#8002)

* rm 29-fee

* rm docs

* lint

* add back test

* doc link fix

(cherry picked from commit 972afc2)

Co-authored-by: Aditya <14364734+AdityaSripal@users.noreply.github.com>

* feat: add cli commands for client v2 counterparty (#7997) (#8007)

* feat: add client counterparty cli commands

* chore: make wasm simapp possible to run more than once

* add query to cli

* lint

(cherry picked from commit eeb8b8a)

Co-authored-by: Gjermund Garaba <gjermund@garaba.net>

* chore: add deprecated functions for backwards compat (#8005) (#8009)

* chore: add back some deprecated functions

* Added DenomPathFromHash as deprecated function

* fix docstring

(cherry picked from commit 7bd0c6d)

Co-authored-by: Gjermund Garaba <gjermund@garaba.net>

* chore: add backport mergify tasks (#7989) (#8015)

* chore: add backport mergify tasks

* add wasm ibc v10 to mergify backports

(cherry picked from commit 11488cf)

Co-authored-by: Gjermund Garaba <gjermund@garaba.net>

* chore: use ibc v2 name consistently (#8006) (#8017)

(cherry picked from commit a71577c)

Co-authored-by: Gjermund Garaba <gjermund@garaba.net>

* callbacks: Error on RecvPacket callback execution (#8014) (#8020)

* change behavior of recvPacket

* fix tests

* error on malformed callback data

* CHANGELOG

---------

Co-authored-by: Gjermund Garaba <gjermund@garaba.net>
(cherry picked from commit c5a36e4)

Co-authored-by: Aditya <14364734+AdityaSripal@users.noreply.github.com>

* chore(deps): bump google.golang.org/protobuf from 1.36.4 to 1.36.5 (#7920) (#8021)

* chore(deps): bump google.golang.org/protobuf from 1.36.4 to 1.36.5

Bumps google.golang.org/protobuf from 1.36.4 to 1.36.5.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* tidy

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Gjermund Garaba <gjermund@garaba.net>
(cherry picked from commit af5b171)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump golangci/golangci-lint-action from 6.2.0 to 6.4.1 (#7969) (#8022)

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 6.2.0 to 6.4.1.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v6.2.0...v6.4.1)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com>
(cherry picked from commit 1f11107)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Gjermund Garaba <gjermund@garaba.net>

* chore: remove remnants of ics20-2 (#8016) (#8045)

* chore: remove remnants of ics20-2

* rename FungibleTokenPacketDataV2 to make it clear that its an internal type

* fix broken link

(cherry picked from commit 40f3240)

Co-authored-by: Gjermund Garaba <gjermund@garaba.net>

* chore(deps): bump JamesIves/github-pages-deploy-action (#7991) (#8048)

Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.7.2 to 4.7.3.
- [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases)
- [Commits](JamesIves/github-pages-deploy-action@v4.7.2...v4.7.3)

---
updated-dependencies:
- dependency-name: JamesIves/github-pages-deploy-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 205e6af)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump golangci/golangci-lint-action from 6.4.1 to 6.5.0 (#7983) (#8049)

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 6.4.1 to 6.5.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v6.4.1...v6.5.0)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Gjermund Garaba <gjermund@garaba.net>
(cherry picked from commit 272c09b)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: remove channel upgradability (#8008) (#8053)

* feat: remove channel upgradability

* lint

* basic migration setup

* feat: remove channel upgradeability

* fix docs

* register v10 migration in app module

* error on upgrading channels + code review fixes

(cherry picked from commit f7b24e1)

Co-authored-by: Gjermund Garaba <gjermund@garaba.net>

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Aditya <14364734+AdityaSripal@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Author: 4 people

.github/mergify.yml

@@ -38,6 +38,14 @@ pull_request_rules:
       backport:
         branches:
           - callbacks/release/v0.2.x+ibc-go-v8.0.x
+  - name: backport patches to v0.3.x callbacks ibc-go v10.0.x branch
+    conditions:
+      - base=main
+      - label=backport-callbacks-to-v0.3.x+ibc-go-v10.0.x
+    actions:
+      backport:
+        branches:
+          - callbacks/release/v0.3.x+ibc-go-v10.0.x
   - name: backport patches to v0.3.x wasm ibc-go v7.4.x & wasmvm 1.5.x branch
     conditions:
       - base=main
@@ -70,6 +78,14 @@ pull_request_rules:
       backport:
         branches:
           - 08-wasm/release/v0.5.x+ibc-go-v8.4.x-wasmvm-v2.1.x
+  - name: backport patches to v0.6.x wasm ibc-go v10.0.x & wasmvm 2.2.x branch
+    conditions:
+      - base=main
+      - label=backport-wasm-v0.6.x+ibc-go-v10.0.x-wasmvm-v2.2.x
+    actions:
+      backport:
+        branches:
+          - 08-wasm/release/v0.6.x+ibc-go-v10.0.x-wasmvm-v2.2.x
   - name: backport patches to v7.4.x branch
     conditions:
       - base=main

.github/workflows/callbacks.yml

@@ -21,7 +21,7 @@ jobs:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      - uses: golangci/golangci-lint-action@v6.2.0
+      - uses: golangci/golangci-lint-action@v6.5.0
         with:
           version: v1.62
           only-new-issues: true

.github/workflows/deploy-docs.yml

@@ -27,7 +27,7 @@ jobs:
         run: make build-docs
 
       - name: Deploy 🚀
-        uses: JamesIves/github-pages-deploy-action@v4.7.2
+        uses: JamesIves/github-pages-deploy-action@v4.7.3
         with:
           branch: gh-pages
           folder: docs/build

.github/workflows/e2e-compatibility.yaml

@@ -236,24 +236,6 @@ jobs:
       test-file: "e2e/tests/transfer/send_receive_test.go"
       release-version: "${{ needs.determine-image-tag.outputs.release-version }}"
 
-  transfer-upgrades-v1-test:
-    needs:
-      - build-release-images
-      - determine-image-tag
-    uses: ./.github/workflows/e2e-compatibility-workflow-call.yaml
-    with:
-      test-file: "e2e/tests/transfer/upgradesv1_test.go"
-      release-version: "${{ needs.determine-image-tag.outputs.release-version }}"
-
-  transfer-upgrades-v2-test:
-    needs:
-      - build-release-images
-      - determine-image-tag
-    uses: ./.github/workflows/e2e-compatibility-workflow-call.yaml
-    with:
-      test-file: "e2e/tests/transfer/upgradesv2_test.go"
-      release-version: "${{ needs.determine-image-tag.outputs.release-version }}"
-
   upgrade-genesis-test:
     needs:
       - build-release-images

.github/workflows/e2emodule.yml

@@ -22,7 +22,7 @@ jobs:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      - uses: golangci/golangci-lint-action@v6.2.0
+      - uses: golangci/golangci-lint-action@v6.5.0
         with:
           version: v1.62
           only-new-issues: true

.github/workflows/golangci-feature.yml

@@ -27,7 +27,7 @@ jobs:
         with:
           fetch-depth: 0
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v6.2.0
+        uses: golangci/golangci-lint-action@v6.5.0
         with:
           version: v1.62
           only-new-issues: true

.github/workflows/golangci.yml

@@ -23,7 +23,7 @@ jobs:
         with:
           fetch-depth: 0
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v6.2.0
+        uses: golangci/golangci-lint-action@v6.5.0
         with:
           version: v1.62
           only-new-issues: true

.github/workflows/wasm-client.yml

@@ -20,7 +20,7 @@ jobs:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      - uses: golangci/golangci-lint-action@v6.2.0
+      - uses: golangci/golangci-lint-action@v6.5.0
         with:
           version: v1.62
           only-new-issues: true

CHANGELOG.md

@@ -93,6 +93,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
 ### State Machine Breaking
 
 * (light-clients/06-solomachine) [\#6313](https://github.com/cosmos/ibc-go/pull/6313) Fix: No-op to avoid panicking on `UpdateState` for invalid misbehaviour submissions.
+* (apps/callbacks) [\#8014](https://github.com/cosmos/ibc-go/pull/8014) Callbacks will now return an error acknowledgement if the recvPacket callback fails. This reverts all app callback changes whereas before we only reverted the callback changes. We also error on all callbacks if the callback data is set but malformed whereas before we ignored the error and continued processing.
 
 ### Improvements
 

README.md

@@ -122,9 +122,7 @@ The following audits have been performed on the `ibc-go` source code:
 
 3. **Middleware**
 
-   3.1 [ICS 29 Fee Middleware](https://github.com/cosmos/ibc-go/tree/main/modules/apps/29-fee)
-
-    3.2 [Callbacks Middleware](https://github.com/cosmos/ibc-go/tree/main/modules/apps/callbacks)
+    3.1 [Callbacks Middleware](https://github.com/cosmos/ibc-go/tree/main/modules/apps/callbacks)
 
 4. **Light Clients**