Skip to content

Commit c9a2f3c

Browse files
committed
docs: added pickup doc
1 parent 908ecbe commit c9a2f3c

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

modules/apps/27-gmp/PICKUP.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,8 @@
11
# GMP pickup document
2-
Here we summarise the top features, fixes and refactors that need completing in the GMP stack to get it closer to production readiness.
2+
3+
`27-gmp` application is feature complete, however, it is not yet production ready. This document outlines the remaining tasks to make it production ready.
4+
5+
- `BuildAddressPredictable` should be audited and tested for security. Specifcally, what happens if the address was created by sending the address some coins first?
6+
- `DeserializeCosmosTx` supports both protobuf encoding and protojson encoding. However, the support for this is hacky since it tries to decode the tx using both methods and returns the one that works. It would be better to have a more robust way to determine the encoding of the tx.
7+
- Add unit tests and integration tests for the `27-gmp` module. Right now, there are no tests for this module.
8+
- End to end tests should be added to ensure the entire flow works as expected. End to end tests should be added to this repository if Cosmos to Cosmos calls are to be supported, otherwise, the end to end tests in the `solidity-ibc-go` repository should be sufficient.

0 commit comments

Comments
 (0)