Skip to content

Commit f372cca

Browse files
authored
fix: remove AskUserQuestion from allowed-tools to restore interactive picker (#504)
AskUserQuestion listed in allowed-tools causes the permission system to auto-approve it, bypassing the requiresUserInteraction() guard that renders the interactive picker. Removing it from all command and agent frontmatter forces AskUserQuestion through the normal permission path where the picker actually renders. Fixes #503
1 parent 8ccc4bd commit f372cca

File tree

10 files changed

+10
-10
lines changed

10 files changed

+10
-10
lines changed

agents/contribution-strategist.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ User wants help with goal-setting.
4040

4141
model: inherit
4242
color: magenta
43-
tools: ["Bash", "Read", "Write", "AskUserQuestion", "mcp__*"]
43+
tools: ["Bash", "Read", "Write", "mcp__*"]
4444
---
4545

4646
> **Input validation:** The "AskUserQuestion Validation Protocol" from `commands/oss.md` applies to ALL `AskUserQuestion` calls in this agent. After every call, check for empty/missing answers and fall back to text-based input if the picker auto-completed.

agents/issue-scout.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ User wants to evaluate a specific issue before investing time.
2222

2323
model: inherit
2424
color: green
25-
tools: ["Bash", "Read", "Write", "AskUserQuestion", "mcp__*"]
25+
tools: ["Bash", "Read", "Write", "mcp__*"]
2626
---
2727

2828
> **Input validation:** The "AskUserQuestion Validation Protocol" from `commands/oss.md` applies to ALL `AskUserQuestion` calls in this agent. After every call, check for empty/missing answers and fall back to text-based input if the picker auto-completed.

agents/pr-compliance-checker.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ User wants pre-submission guidance on PR quality.
3131

3232
model: inherit
3333
color: orange
34-
tools: ["Bash", "Read", "Glob", "Grep", "WebFetch", "AskUserQuestion", "mcp__*"]
34+
tools: ["Bash", "Read", "Glob", "Grep", "WebFetch", "mcp__*"]
3535
---
3636

3737
> **Input validation:** The "AskUserQuestion Validation Protocol" from `commands/oss.md` applies to ALL `AskUserQuestion` calls in this agent. After every call, check for empty/missing answers and fall back to text-based input if the picker auto-completed.

agents/pr-health-checker.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ Merge conflicts are a health issue this agent handles.
3131

3232
model: inherit
3333
color: yellow
34-
tools: ["Bash", "Read", "Write", "Grep", "AskUserQuestion", "mcp__*"]
34+
tools: ["Bash", "Read", "Write", "Grep", "mcp__*"]
3535
---
3636

3737
> **Input validation:** The "AskUserQuestion Validation Protocol" from `commands/oss.md` applies to ALL `AskUserQuestion` calls in this agent. After every call, check for empty/missing answers and fall back to text-based input if the picker auto-completed.

agents/pr-responder.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ User needs help understanding and responding to a specific code review comment.
2222

2323
model: inherit
2424
color: cyan
25-
tools: ["Bash", "Read", "Glob", "Grep", "AskUserQuestion", "mcp__*"]
25+
tools: ["Bash", "Read", "Glob", "Grep", "mcp__*"]
2626
---
2727

2828
> **Input validation:** The "AskUserQuestion Validation Protocol" from `commands/oss.md` applies to ALL `AskUserQuestion` calls in this agent. After every call, check for empty/missing answers and fall back to text-based input if the picker auto-completed.

agents/pre-commit-reviewer.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ Post-conflict resolution is a critical moment where bugs can be introduced. Revi
2222

2323
model: inherit
2424
color: red
25-
tools: ["Bash", "Read", "Glob", "Grep", "AskUserQuestion", "mcp__*"]
25+
tools: ["Bash", "Read", "Glob", "Grep", "mcp__*"]
2626
---
2727

2828
> **Input validation:** The "AskUserQuestion Validation Protocol" from `commands/oss.md` applies to ALL `AskUserQuestion` calls in this agent. After every call, check for empty/missing answers and fall back to text-based input if the picker auto-completed.

agents/repo-evaluator.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ User wants to predict maintainer engagement before contributing.
2222

2323
model: inherit
2424
color: blue
25-
tools: ["Bash", "Read", "Write", "Glob", "AskUserQuestion", "mcp__*"]
25+
tools: ["Bash", "Read", "Write", "Glob", "mcp__*"]
2626
---
2727

2828
> **Input validation:** The "AskUserQuestion Validation Protocol" from `commands/oss.md` applies to ALL `AskUserQuestion` calls in this agent. After every call, check for empty/missing answers and fall back to text-based input if the picker auto-completed.

commands/oss-search.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
name: oss-search
33
description: "Search for new open source issues to contribute to — parallel multi-strategy search with vetting"
4-
allowed-tools: Bash, Read, Write, Edit, Glob, Grep, AskUserQuestion, Task, mcp__*
4+
allowed-tools: Bash, Read, Write, Edit, Glob, Grep, Task, mcp__*
55
---
66

77
# OSS Issue Search

commands/oss.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
name: oss
33
description: "Daily OSS contribution check - uses CLI with --json for structured data"
4-
allowed-tools: Bash, Read, Write, Edit, Glob, Grep, AskUserQuestion, Task, mcp__*
4+
allowed-tools: Bash, Read, Write, Edit, Glob, Grep, Task, mcp__*
55
---
66

77
# OSS Autopilot Daily Check

commands/setup-oss.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
name: setup-oss
33
description: Configure OSS autopilot preferences
4-
allowed-tools: Bash, Write, Read, Glob, AskUserQuestion, mcp__*
4+
allowed-tools: Bash, Write, Read, Glob, mcp__*
55
---
66

77
# OSS Autopilot Setup

0 commit comments

Comments
 (0)