-
Notifications
You must be signed in to change notification settings - Fork 2
Closed
Description
Problem
During the nickel-lang/nickel#2529 PR workflow, the code review loop was not part of the standard workflow. The user had to explicitly request "use the pr-review-toolkit to review the PR and fix issues in a loop until they converge."
The review caught real issues (flag naming, missing manual update, terse help text) that should have been caught automatically before the PR was marked ready.
Proposal
Add a review-fix-converge loop as a standard step in the draft-first workflow:
- After creating the draft PR, automatically run a code review
- Fix any issues found
- Re-review until no issues remain
- Only then proceed to mark the PR ready
This prevents shipping reviewable issues to maintainers and reduces review round-trips.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels