Skip to content

Integrate review-fix loop into draft-first workflow #371

@costajohnt

Description

@costajohnt

Problem

During the nickel-lang/nickel#2529 PR workflow, the code review loop was not part of the standard workflow. The user had to explicitly request "use the pr-review-toolkit to review the PR and fix issues in a loop until they converge."

The review caught real issues (flag naming, missing manual update, terse help text) that should have been caught automatically before the PR was marked ready.

Proposal

Add a review-fix-converge loop as a standard step in the draft-first workflow:

  1. After creating the draft PR, automatically run a code review
  2. Fix any issues found
  3. Re-review until no issues remain
  4. Only then proceed to mark the PR ready

This prevents shipping reviewable issues to maintainers and reduces review round-trips.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions