Skip to content

Commit 5b26522

Browse files
committed
Woops. Add $ to conditional.
1 parent 918a373 commit 5b26522

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

.github/workflows/phpunit-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545
fail-fast: false
4646
matrix:
4747
os: [ ubuntu-latest ]
48-
php: [ '7.2' ]
48+
php: [ '7.4' ]
4949
db-type: [ 'mysql' ]
5050
db-version: [ '5.7' ]
5151
tests-domain: [ 'example.org' ]

.github/workflows/reusable-phpunit-tests.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ on:
3434
description: 'Whether to test with memcached enabled'
3535
required: false
3636
type: 'boolean'
37-
default:
37+
default: false
3838
html5lib-tests:
3939
description: 'Whether to run the html5lib tests'
4040
required: false
@@ -161,11 +161,11 @@ jobs:
161161
run: npm run env:install
162162

163163
- name: Run PHPUnit tests
164-
if: {{ ! inputs.html5lib-tests }}
164+
if: ${{ ! inputs.html5lib-tests }}
165165
run: node ./tools/local-env/scripts/docker.js run php ./vendor/bin/phpunit --verbose -c ${{ env.PHPUNIT_CONFIG }}
166166

167167
- name: Run AJAX tests
168-
if: {{ ! inputs.html5lib-tests }}
168+
if: ${{ ! inputs.html5lib-tests }}
169169
run: node ./tools/local-env/scripts/docker.js run php ./vendor/bin/phpunit --verbose -c ${{ env.PHPUNIT_CONFIG }} --group ajax
170170

171171
- name: Run ms-files tests as a multisite install
@@ -178,7 +178,7 @@ jobs:
178178

179179
- name: Check if the HTML API was modified
180180
id: check-for-html-api-changes
181-
if: {{ inputs.html5lib-tests }}
181+
if: ${{ inputs.html5lib-tests }}
182182
uses: tj-actions/changed-files@v44
183183
with:
184184
files: |
@@ -188,7 +188,7 @@ jobs:
188188
.github/workflows/html5lib-tests.yml
189189
190190
- name: Run html5lib tests
191-
if: {{ inputs.html5lib-tests && steps.check-for-html-api-changes.outputs.any_changed == 'true' }}
191+
if: ${{ inputs.html5lib-tests && steps.check-for-html-api-changes.outputs.any_changed == 'true' }}
192192
run: node ./tools/local-env/scripts/docker.js run php ./vendor/bin/phpunit --verbose -c ${{ env.PHPUNIT_CONFIG }} --group html-api-html5lib-tests
193193

194194
# __fakegroup__ is excluded to force PHPUnit to ignore the <exclude> settings in phpunit.xml.dist.

0 commit comments

Comments
 (0)