chore: warn on clippy::allow_attributes; fix clippy warnings (#363)

Author: m4tx

Cargo.toml

@@ -47,6 +47,7 @@ rust_2018_idioms = { level = "warn", priority = -1 }
 all = { level = "deny", priority = -1 }
 pedantic = "warn"
 future_not_send = "warn"
+allow_attributes = "warn"
 
 [workspace.dependencies]
 ahash = { version = "0.8.11", default-features = false }
@@ -104,8 +105,8 @@ proc-macro2 = { version = "1", default-features = false }
 quote = { version = "1", default-features = false }
 rand = { version = "0.9", default-features = false }
 rustversion = "1"
-redis = { version =  "0.29.1", default-features = false }
-deadpool-redis = { version =  "0.20.0", default-features = false }
+redis = { version = "0.29.1", default-features = false }
+deadpool-redis = { version = "0.20.0", default-features = false }
 schemars = { version = "0.8.22", default-features = false }
 sea-query = { version = "0.32", default-features = false }
 sea-query-binder = { version = "0.7", default-features = false }

cot-cli/src/migration_generator.rs

@@ -1263,7 +1263,7 @@ impl DynMigration for Migration {
 /// This is used to generate migration files.
 #[derive(Debug, Clone, PartialEq, Eq, Hash)]
 // this is not frequently used, so we don't mind extra memory usage
-#[allow(clippy::large_enum_variant)]
+#[expect(clippy::large_enum_variant)]
 pub enum DynDependency {
     Migration { app: String, migration: String },
     Model { model_type: syn::Type },

cot/src/db.rs

@@ -120,7 +120,7 @@ pub type Result<T> = std::result::Result<T, DatabaseError>;
     note = "annotate `{Self}` with the `#[cot::db::model]` attribute"
 )]
 pub trait Model: Sized + Send + 'static {
-    #[allow(clippy::doc_markdown)] // UPPER_SNAKE_CASE
+    #[expect(clippy::doc_markdown, reason = "UPPER_SNAKE_CASE")]
     /// A helper structure for the fields of the model.
     ///
     /// This structure should a constant [`FieldRef`](query::FieldRef) instance

cot/src/db/fields.rs

@@ -170,8 +170,12 @@ macro_rules! impl_db_field_with_postgres_int_cast {
 
             #[cfg(feature = "postgres")]
             fn from_postgres(value: PostgresValueRef<'_>) -> Result<Self> {
-                #[allow(clippy::cast_possible_truncation)]
-                #[allow(clippy::cast_sign_loss)]
+                #[allow(
+                    clippy::allow_attributes,
+                    clippy::cast_possible_truncation,
+                    clippy::cast_sign_loss,
+                    reason = "needed for casting from larger to smaller integer types"
+                )]
                 value.get::<$src_ty>().map(|v| v as $dest_ty)
             }
         }
@@ -183,8 +187,12 @@ macro_rules! impl_db_field_with_postgres_int_cast {
 
             #[cfg(feature = "postgres")]
             fn from_postgres(value: PostgresValueRef<'_>) -> Result<Self> {
-                #[allow(clippy::cast_possible_truncation)]
-                #[allow(clippy::cast_sign_loss)]
+                #[allow(
+                    clippy::allow_attributes,
+                    clippy::cast_possible_truncation,
+                    clippy::cast_sign_loss,
+                    reason = "needed for casting from larger to smaller integer types"
+                )]
                 value
                     .get::<Option<$src_ty>>()
                     .map(|v| v.map(|v| v as $dest_ty))

cot/src/form/fields.rs

@@ -1221,7 +1221,7 @@ mod tests {
     }
 
     #[cot::test]
-    #[allow(clippy::float_cmp)]
+    #[expect(clippy::float_cmp)]
     async fn float_field_clean_value() {
         let mut field = FloatField::<f32>::with_options(
             FormFieldOptions {

cot/src/handler.rs

@@ -80,9 +80,18 @@ macro_rules! impl_request_handler {
             Fut: Future<Output = R> + Send,
             R: IntoResponse,
         {
-            #[allow(non_snake_case)]
+            #[allow(
+                clippy::allow_attributes,
+                non_snake_case,
+                reason = "for the case where there are no params"
+            )]
             async fn handle(&self, request: Request) -> Result<Response> {
-                #[allow(unused_variables, unused_mut)] // for the case where there are no params
+                #[allow(
+                    clippy::allow_attributes,
+                    unused_variables,
+                    unused_mut,
+                    reason = "for the case where there are no params"
+                )]
                 let (mut parts, _body) = request.into_parts();
 
                 $(
@@ -106,9 +115,17 @@ macro_rules! impl_request_handler_from_request {
             Fut: Future<Output = R> + Send,
             R: IntoResponse,
         {
-            #[expect(non_snake_case)]
+            #[allow(
+                clippy::allow_attributes,
+                non_snake_case,
+                reason = "for the case where there are no FromRequestParts params"
+            )]
             async fn handle(&self, request: Request) -> Result<Response> {
-                #[allow(unused_mut)] // for the case where there are no FromRequestParts params
+                #[allow(
+                    clippy::allow_attributes,
+                    unused_mut,
+                    reason = "for the case where there are no FromRequestParts params"
+                )]
                 let (mut parts, body) = request.into_parts();
 
                 $(

cot/src/openapi.rs

@@ -512,7 +512,11 @@ macro_rules! impl_as_openapi_operation {
             R: for<'a> Future<Output = Response> + Send,
             Response: ApiOperationResponse,
         {
-            #[allow(non_snake_case)]
+            #[allow(
+                clippy::allow_attributes,
+                non_snake_case,
+                reason = "for the case where there are no FromRequestParts params"
+            )]
             fn as_api_operation(
                 &self,
                 route_context: &RouteContext<'_>,

cot/src/request/path_params_deserializer.rs

@@ -649,7 +649,7 @@ mod tests {
     macro_rules! test_deserialize_value {
         ($test_name:ident, $ty:ty, $value:literal, $expected:literal) => {
             #[test]
-            #[allow(clippy::float_cmp)]
+            #[allow(clippy::allow_attributes, clippy::float_cmp)]
             fn $test_name() {
                 let path_params = create_path_params([("some_name", $value)]);
                 let deserializer = PathParamsDeserializer::new(&path_params);

cot/src/router.rs

@@ -862,7 +862,11 @@ where
 #[macro_export]
 macro_rules! reverse {
     ($request:expr, $view_name:literal $(, $($key:ident = $value:expr),*)?) => {{
-        #[allow(unused_imports)] // allow using either `Request` or `Urls` objects
+        #[allow(
+            clippy::allow_attributes,
+            unused_imports,
+            reason = "allow using either `Request` or `Urls` objects"
+        )]
         use $crate::request::RequestExt;
         let (app_name, view_name) = $crate::router::split_view_name($view_name);
         let app_name = app_name.or_else(|| $request.app_name());

cot/src/router/path.rs

@@ -256,8 +256,10 @@ impl ReverseParamMap {
 #[doc(hidden)]
 #[macro_export]
 macro_rules! reverse_param_map {
+    () => {{
+        $crate::router::path::ReverseParamMap::new()
+    }};
     ($($key:ident = $value:expr),*) => {{
-        #[allow(unused_mut)] // for the case when there are no parameters
         let mut map = $crate::router::path::ReverseParamMap::new();
         $( map.insert(stringify!($key), &$value); )*
         map