Skip to content

Commit 33daa4b

Browse files
committed
Refactor test code and update dependencies
1 parent 921356b commit 33daa4b

File tree

3 files changed

+32
-28
lines changed

3 files changed

+32
-28
lines changed

.github/workflows/tests.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,10 @@ jobs:
4141
- name: Run Maven Tests
4242
id: run
4343
run: |
44-
mvn test "-Dtest=org.couchbase.quickstart.springdata.controllers.*Test"
45-
44+
chmod +x mvnw
45+
./mvnw clean
46+
./mvnw test "-Dtest=org.couchbase.quickstart.springdata.controllers.*Test" -X
47+
4648
- name: Report Status
4749
if: always()
4850
uses: ravsamhq/notify-slack-action@v1

src/test/java/org/couchbase/quickstart/springboot/controllers/AirlineIntegrationTest.java

Lines changed: 17 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import static org.assertj.core.api.Assertions.assertThat;
44

55
import java.util.Arrays;
6+
import java.util.HashMap;
67
import java.util.List;
78
import java.util.Map;
89

@@ -222,27 +223,22 @@ void testListAirlinesByCountry() {
222223

223224
@Test
224225
void testListAirlinesByDestinationAirport() {
225-
Map<String, List<Airline>> expectedAirlinesByDestination = Map.of(
226-
"SFO", Arrays.asList(
227-
Airline.builder().id("3029").type("airline").name("JetBlue Airways")
228-
.iata("B6").icao("JBU")
229-
.callsign("JETBLUE").country("United States").build(),
230-
Airline.builder().id("1355").type("airline").name("British Airways")
231-
.iata("BA").icao("BAW")
232-
.callsign("SPEEDBIRD").country("United Kingdom")
233-
.build()),
234-
// Add more expected airlines for SFO
235-
"MRS", Arrays.asList(
236-
Airline.builder().id("137").type("airline").name("Air France")
237-
.iata("AF").icao("AFR")
238-
.callsign("AIRFRANS").country("France").build(),
239-
Airline.builder().id("24").type("airline").name("American Airlines")
240-
.iata("AA").icao("AAL").callsign("AMERICAN")
241-
.country("United States").build()
242-
// Add more expected airlines for MRS
243-
)
244-
// Add more airports and their expected airlines as needed
245-
);
226+
Map<String, List<Airline>> expectedAirlinesByDestination = new HashMap<>();
227+
228+
expectedAirlinesByDestination.put("SFO", Arrays.asList(
229+
Airline.builder().id("3029").type("airline").name("JetBlue Airways")
230+
.iata("B6").icao("JBU").callsign("JETBLUE").country("United States")
231+
.build(),
232+
Airline.builder().id("1355").type("airline").name("British Airways")
233+
.iata("BA").icao("BAW").callsign("SPEEDBIRD").country("United Kingdom")
234+
.build()));
235+
236+
expectedAirlinesByDestination.put("MRS", Arrays.asList(
237+
Airline.builder().id("137").type("airline").name("Air France")
238+
.iata("AF").icao("AFR").callsign("AIRFRANS").country("France").build(),
239+
Airline.builder().id("24").type("airline").name("American Airlines")
240+
.iata("AA").icao("AAL").callsign("AMERICAN").country("United States")
241+
.build()));
246242

247243
int limit = 10;
248244
int offset = 0;

src/test/java/org/couchbase/quickstart/springboot/controllers/AirportIntegrationTest.java

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import static org.assertj.core.api.Assertions.assertThat;
44

55
import java.util.Arrays;
6+
import java.util.HashMap;
67
import java.util.List;
78
import java.util.Map;
89

@@ -149,11 +150,16 @@ void testListAirports() {
149150
@Test
150151
void testListDirectConnections() {
151152
List<String> destinationAirportCodes = Arrays.asList("SFO", "LAX", "JFK", "MRS");
152-
Map<String, List<String>> expectedDirectConnections = Map.of(
153-
"SFO", Arrays.asList("JFK", "HKG", "ICN", "ATL", "BJX", "GDL", "MEX", "MLM", "PVR", "SJD"),
154-
"LAX", Arrays.asList("NRT", "CUN", "GDL", "HMO", "MEX", "MZT", "PVR", "SJD", "ZIH", "ZLO"),
155-
"JFK", Arrays.asList("DEL", "LHR", "EZE", "ATL", "CUN", "MEX", "EZE", "LAX", "SAN", "SEA"),
156-
"MRS", Arrays.asList("AAE", "ALG", "BJA", "BLJ", "CZL", "ORN", "QSF", "TLM", "CDG", "CMN"));
153+
154+
Map<String, List<String>> expectedDirectConnections = new HashMap<>();
155+
expectedDirectConnections.put("SFO",
156+
Arrays.asList("JFK", "HKG", "ICN", "ATL", "BJX", "GDL", "MEX", "MLM", "PVR", "SJD"));
157+
expectedDirectConnections.put("LAX",
158+
Arrays.asList("NRT", "CUN", "GDL", "HMO", "MEX", "MZT", "PVR", "SJD", "ZIH", "ZLO"));
159+
expectedDirectConnections.put("JFK",
160+
Arrays.asList("DEL", "LHR", "EZE", "ATL", "CUN", "MEX", "EZE", "LAX", "SAN", "SEA"));
161+
expectedDirectConnections.put("MRS",
162+
Arrays.asList("AAE", "ALG", "BJA", "BLJ", "CZL", "ORN", "QSF", "TLM", "CDG", "CMN"));
157163

158164
for (String airportCode : destinationAirportCodes) {
159165
int limit = 10;

0 commit comments

Comments
 (0)