Skip to content

Commit 3745a33

Browse files
committed
Add ResourceAccessException to catch block in integration tests
1 parent f6cff34 commit 3745a33

File tree

3 files changed

+12
-15
lines changed

3 files changed

+12
-15
lines changed

src/test/java/org/couchbase/quickstart/springdata/controllers/AirlineIntegrationTest.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
import org.springframework.http.HttpMethod;
1818
import org.springframework.http.HttpStatus;
1919
import org.springframework.http.ResponseEntity;
20+
import org.springframework.web.client.ResourceAccessException;
2021

2122
import com.couchbase.client.core.error.DocumentNotFoundException;
2223

@@ -43,10 +44,10 @@ private void deleteAirline(String baseUri, String airlineId) {
4344
if (airlineService.getAirlineById(airlineId).isPresent()) {
4445
restTemplate.delete(baseUri + "/api/v1/airline/" + airlineId);
4546
}
46-
} catch (DocumentNotFoundException | DataRetrievalFailureException e) {
47-
log.error("Document not found");
47+
} catch (DocumentNotFoundException | DataRetrievalFailureException | ResourceAccessException e) {
48+
log.warn("Document " + airlineId + " not present prior to test");
4849
} catch (Exception e) {
49-
log.error("Error deleting test data");
50+
log.error("Error deleting test data", e.getMessage());
5051
}
5152
}
5253

@@ -69,14 +70,12 @@ private String getBaseUri() {
6970
@BeforeEach
7071
void setUp() {
7172
String baseUri = getBaseUri();
72-
log.info("baseUri: " + baseUri);
7373
deleteTestAirlineData(baseUri);
7474
}
7575

7676
@AfterEach
7777
void tearDown() {
7878
String baseUri = getBaseUri();
79-
log.info("baseUri: " + baseUri);
8079
deleteTestAirlineData(baseUri);
8180
}
8281

src/test/java/org/couchbase/quickstart/springdata/controllers/AirportIntegrationTest.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import org.springframework.http.HttpMethod;
1919
import org.springframework.http.HttpStatus;
2020
import org.springframework.http.ResponseEntity;
21+
import org.springframework.web.client.ResourceAccessException;
2122

2223
import com.couchbase.client.core.error.DocumentNotFoundException;
2324

@@ -44,10 +45,10 @@ private void deleteAirport(String baseUri, String airportId) {
4445
if (airportService.getAirportById(airportId).isPresent()) {
4546
restTemplate.delete(baseUri + "/api/v1/airport/" + airportId);
4647
}
47-
} catch (DocumentNotFoundException | DataRetrievalFailureException e) {
48-
log.error("Document not found");
48+
} catch (DocumentNotFoundException | DataRetrievalFailureException | ResourceAccessException e) {
49+
log.warn("Document " + airportId + " not present prior to test");
4950
} catch (Exception e) {
50-
log.error("Error deleting test data");
51+
log.error("Error deleting test data", e.getMessage());
5152
}
5253
}
5354

@@ -70,14 +71,12 @@ private String getBaseUri() {
7071
@BeforeEach
7172
void setUp() {
7273
String baseUri = getBaseUri();
73-
log.info("baseUri: " + baseUri);
7474
deleteTestAirportData(baseUri);
7575
}
7676

7777
@AfterEach
7878
void tearDown() {
7979
String baseUri = getBaseUri();
80-
log.info("baseUri: " + baseUri);
8180
deleteTestAirportData(baseUri);
8281
}
8382

src/test/java/org/couchbase/quickstart/springdata/controllers/RouteIntegrationTest.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import org.springframework.http.HttpMethod;
2121
import org.springframework.http.HttpStatus;
2222
import org.springframework.http.ResponseEntity;
23+
import org.springframework.web.client.ResourceAccessException;
2324

2425
import com.couchbase.client.core.error.DocumentNotFoundException;
2526

@@ -46,10 +47,10 @@ private void deleteRoute(String baseUri, String routeId) {
4647
if (routeService.getRouteById(routeId).isPresent()) {
4748
restTemplate.delete(baseUri + "/api/v1/route/" + routeId);
4849
}
49-
} catch (DocumentNotFoundException | DataRetrievalFailureException e) {
50-
log.error("Document not found");
50+
} catch (DocumentNotFoundException | DataRetrievalFailureException | ResourceAccessException e) {
51+
log.warn("Document " + routeId + " not present prior to test");
5152
} catch (Exception e) {
52-
log.error("Error deleting test data");
53+
log.error("Error deleting test data", e.getMessage());
5354
}
5455
}
5556

@@ -72,14 +73,12 @@ private String getBaseUri() {
7273
@BeforeEach
7374
void setUp() {
7475
String baseUri = getBaseUri();
75-
log.info("baseUri: " + baseUri);
7676
deleteTestRouteData(baseUri);
7777
}
7878

7979
@AfterEach
8080
void tearDown() {
8181
String baseUri = getBaseUri();
82-
log.info("baseUri: " + baseUri);
8382
deleteTestRouteData(baseUri);
8483
}
8584

0 commit comments

Comments
 (0)