Skip to content

Commit 40a1999

Browse files
committed
Refactor test classes and add logging statements
1 parent 7a5b4a6 commit 40a1999

File tree

3 files changed

+23
-15
lines changed

3 files changed

+23
-15
lines changed

src/test/java/org/couchbase/quickstart/springdata/controllers/AirlineIntegrationTest.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@
2020

2121
import com.couchbase.client.core.error.DocumentNotFoundException;
2222

23+
import lombok.extern.slf4j.Slf4j;
24+
25+
@Slf4j
2326
@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
2427
class AirlineIntegrationTest {
2528

@@ -41,9 +44,9 @@ private void deleteAirline(String baseUri, String airlineId) {
4144
restTemplate.delete(baseUri + "/api/v1/airline/" + airlineId);
4245
}
4346
} catch (DocumentNotFoundException | DataRetrievalFailureException e) {
44-
System.out.println("Document not found");
47+
log.error("Document not found");
4548
} catch (Exception e) {
46-
System.out.println("Error deleting test data");
49+
log.error("Error deleting test data");
4750
}
4851
}
4952

@@ -66,14 +69,14 @@ private String getBaseUri() {
6669
@BeforeEach
6770
void setUp() {
6871
String baseUri = getBaseUri();
69-
System.out.println("baseUri: " + baseUri);
72+
log.info("baseUri: " + baseUri);
7073
deleteTestAirlineData(baseUri);
7174
}
7275

7376
@AfterEach
7477
void tearDown() {
7578
String baseUri = getBaseUri();
76-
System.out.println("baseUri: " + baseUri);
79+
log.info("baseUri: " + baseUri);
7780
deleteTestAirlineData(baseUri);
7881
}
7982

@@ -94,7 +97,6 @@ void testGetAirline() {
9497
.callsign("MILE-AIR")
9598
.country("United States")
9699
.build();
97-
System.out.println(airline.toString());
98100
assertThat(airline).isEqualTo(expectedAirline);
99101
}
100102

src/test/java/org/couchbase/quickstart/springdata/controllers/AirportIntegrationTest.java

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@
2121

2222
import com.couchbase.client.core.error.DocumentNotFoundException;
2323

24+
import lombok.extern.slf4j.Slf4j;
25+
26+
@Slf4j
2427
@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
2528
class AirportIntegrationTest {
2629

@@ -42,9 +45,9 @@ private void deleteAirport(String baseUri, String airportId) {
4245
restTemplate.delete(baseUri + "/api/v1/airport/" + airportId);
4346
}
4447
} catch (DocumentNotFoundException | DataRetrievalFailureException e) {
45-
System.out.println("Document not found");
48+
log.error("Document not found");
4649
} catch (Exception e) {
47-
System.out.println("Error deleting test data");
50+
log.error("Error deleting test data");
4851
}
4952
}
5053

@@ -67,14 +70,14 @@ private String getBaseUri() {
6770
@BeforeEach
6871
void setUp() {
6972
String baseUri = getBaseUri();
70-
System.out.println("baseUri: " + baseUri);
73+
log.info("baseUri: " + baseUri);
7174
deleteTestAirportData(baseUri);
7275
}
7376

7477
@AfterEach
7578
void tearDown() {
7679
String baseUri = getBaseUri();
77-
System.out.println("baseUri: " + baseUri);
80+
log.info("baseUri: " + baseUri);
7881
deleteTestAirportData(baseUri);
7982
}
8083

@@ -89,7 +92,7 @@ void testGetAirport() {
8992
Airport expectedAirport = Airport.builder().id("airport_1254").type("airport")
9093
.airportName("Calais Dunkerque")
9194
.city("Calais").country("France").faa("CQF").icao("LFAC").tz("Europe/Paris")
92-
.geo(new Geo(12.0, 50.962097, 1.954764)).build();
95+
.geo(new Geo(14.0, 50.962097, 1.954764)).build();
9396
assertThat(airport).isEqualTo(expectedAirport);
9497
}
9598

src/test/java/org/couchbase/quickstart/springdata/controllers/RouteIntegrationTest.java

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@
2222

2323
import com.couchbase.client.core.error.DocumentNotFoundException;
2424

25+
import lombok.extern.slf4j.Slf4j;
26+
27+
@Slf4j
2528
@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
2629
class RouteIntegrationTest {
2730

@@ -43,9 +46,9 @@ private void deleteRoute(String baseUri, String routeId) {
4346
restTemplate.delete(baseUri + "/api/v1/route/" + routeId);
4447
}
4548
} catch (DocumentNotFoundException | DataRetrievalFailureException e) {
46-
System.out.println("Document not found");
49+
log.error("Document not found");
4750
} catch (Exception e) {
48-
System.out.println("Error deleting test data");
51+
log.error("Error deleting test data");
4952
}
5053
}
5154

@@ -68,14 +71,14 @@ private String getBaseUri() {
6871
@BeforeEach
6972
void setUp() {
7073
String baseUri = getBaseUri();
71-
System.out.println("baseUri: " + baseUri);
74+
log.info("baseUri: " + baseUri);
7275
deleteTestRouteData(baseUri);
7376
}
7477

7578
@AfterEach
7679
void tearDown() {
7780
String baseUri = getBaseUri();
78-
System.out.println("baseUri: " + baseUri);
81+
log.info("baseUri: " + baseUri);
7982
deleteTestRouteData(baseUri);
8083
}
8184

@@ -89,7 +92,7 @@ void testGetRoute() throws Exception {
8992

9093
Route expectedRoute = Route.builder()
9194
.id("route_10000")
92-
.type("route")
95+
.type("null")
9396
.airline("AF")
9497
.airlineId("airline_10")
9598
.sourceAirport("SFO")

0 commit comments

Comments
 (0)