Skip to content

Commit 9523856

Browse files
committed
Fix flaky test by adding scan consistency to airline query
- Add scanConsistency: RequestPlus to listAirlinesToAirport query - Update .gitignore for Node.js project - Add example env files, remove actual credentials from tracking
1 parent a7616b9 commit 9523856

File tree

4 files changed

+27
-5
lines changed

4 files changed

+27
-5
lines changed

.gitignore

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,24 @@
1-
/node_modules/*
2-
/dist
1+
# Dependencies
2+
node_modules/
33

4-
*.DS_STORE
4+
# Build output
5+
dist/
56

7+
# Environment files
8+
*.env
9+
config/*.env
10+
11+
# OS files
12+
.DS_Store
13+
14+
# IDE
615
.idea/
16+
.vscode/
17+
18+
# Logs
19+
logs/
20+
*.log
21+
npm-debug.log*
22+
23+
# Coverage
24+
coverage/
File renamed without changes.

config/dev.env renamed to config/test.env.example

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@ DB_PASSWORD=
44
DB_BUCKET_NAME=travel-sample
55
IS_CAPELLA=true
66
APP_PORT=3000
7-
DELAY=5000
7+
DELAY=5000

src/controllers/airlineController.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { validateRequiredFields } from '../shared/validateRequiredField'
22
import { connectToDatabase } from '../../db/connection'
33
import { makeResponse } from '../shared/makeResponse'
4+
import * as couchbase from 'couchbase'
45

56
const createAirline = async (req, res) => {
67
const requiredFields = ['name', 'icao', 'country', 'callsign']
@@ -112,7 +113,10 @@ const listAirlinesToAirport = async (req, res) => {
112113
LIMIT $LIMIT
113114
OFFSET $OFFSET;
114115
`
115-
options = { parameters: { AIRPORT: airport, LIMIT: limit, OFFSET: offset } }
116+
options = {
117+
parameters: { AIRPORT: airport, LIMIT: limit, OFFSET: offset },
118+
scanConsistency: couchbase.QueryScanConsistency.RequestPlus,
119+
}
116120
await makeResponse(res, async () => {
117121
let results = await scope.query(query, options)
118122
return results['rows']

0 commit comments

Comments
 (0)