Added CI +updated Airport direct connection + updated test files format

Author: teetangh

.github/workflows/ci.yml

@@ -0,0 +1,43 @@
+name: Continuous Integration
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+    branches: [main]
+  schedule:
+    - cron: "50 9 * * *"
+
+jobs:
+  run_tests:
+    name: Run Tests
+    runs-on: ubuntu-latest
+    env:
+      DB_CONN_STR: ${{ vars.DB_CONN_STR }}
+      DB_USERNAME: ${{ vars.DB_USERNAME }}
+      DB_PASSWORD: ${{ secrets.DB_PASSWORD }}
+      
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 3.3.0
+      - name: Install dependencies
+        run: bundle install
+
+      - name: Run tests
+        run: bundle exec rspec test/integration
+
+      - name: Report Status
+        if: always()
+        uses: ravsamhq/notify-slack-action@v1
+        with:
+          status: ${{ job.status }}
+          notify_when: "failure,warnings"
+          notification_title: "Repo: *{repo}*"
+          message_format: "{emoji}    *{status_message}* in <{repo_url}|{repo}@{branch}> on <{commit_url}|{commit_sha}>"
+          footer: "<{run_url}|View Full Run on GitHub>"
+        env:
+          SLACK_WEBHOOK_URL: ${{ secrets.ACTION_MONITORING_SLACK }}

app/controllers/api/v1/airports_controller.rb

@@ -110,21 +110,19 @@ def index
 
       # GET /api/v1/airports/direct-connections
       def direct_connections
-        raise ArgumentError, 'Source airport is missing' unless params[:sourceAirportCode].present?
+        raise ArgumentError, 'Destination airport is missing' unless params[:destinationAirportCode].present?
 
-        source_airport = params[:sourceAirportCode]
+        destination_airport = params[:destinationAirportCode]
         limit = params[:limit] || 10
         offset = params[:offset] || 0
 
-        begin
-          destination_airports = Route.direct_connections(key: [source_airport, limit, offset])
-                                      .pluck(:destinationairport)
-          render json: destination_airports, status: :ok
-        rescue ArgumentError => e
-          render json: { error: 'Invalid request', message: e.message }, status: :bad_request
-        rescue StandardError => e
-          render json: { error: 'Internal server error', message: e.message }, status: :internal_server_error
-        end
+        destination_airports = Route.direct_connections(key: [destination_airport, limit, offset])
+                                    .pluck(:destinationairport)
+        render json: destination_airports, status: :ok
+      rescue ArgumentError => e
+        render json: { error: 'Invalid request', message: e.message }, status: :bad_request
+      rescue StandardError => e
+        render json: { error: 'Internal server error', message: e.message }, status: :internal_server_error
       end
 
       private

config/couchbase.yml

@@ -1,16 +1,16 @@
 common: &common
+  bucket: travel-sample
+  connection_string: <%= ENV['DB_CONN_STR'] %>
+  username: <%= ENV['DB_USERNAME'] %>
+  password: <%= ENV['DB_PASSWORD'] %>
+
+development:
   connection_string: couchbase://localhost
   username: kaustav
   password: password
 
-development:
-  <<: *common
-  bucket: travel-sample
-
 test:
   <<: *common
-  bucket: travel-sample
 
 production:
-  <<: *common
-  bucket: travel-sample
+  <<: *common

test/integration/airlines_spec.rb

@@ -155,27 +155,25 @@
   end
 
   describe 'GET /api/v1/airlines/list' do
-    let(:country) { 'United States' }
+    let(:country) { 'France' }
     let(:limit) { '10' }
     let(:offset) { '0' }
+
     let(:expected_airlines) do
       [
-        { 'name' => '40-Mile Air', 'iata' => 'Q5', 'icao' => 'MLA', 'callsign' => 'MILE-AIR',
-          'country' => 'United States' },
-        { 'name' => 'Texas Wings', 'iata' => 'TQ', 'icao' => 'TXW', 'callsign' => 'TXW', 'country' => 'United States' },
-        { 'name' => 'Atifly', 'iata' => 'A1', 'icao' => 'A1F', 'callsign' => 'atifly', 'country' => 'United States' },
-        { 'name' => 'Locair', 'iata' => 'ZQ', 'icao' => 'LOC', 'callsign' => 'LOCAIR', 'country' => 'United States' },
-        { 'name' => 'SeaPort Airlines', 'iata' => 'K5', 'icao' => 'SQH', 'callsign' => 'SASQUATCH',
-          'country' => 'United States' },
-        { 'name' => 'Alaska Central Express', 'iata' => 'KO', 'icao' => 'AER', 'callsign' => 'ACE AIR',
-          'country' => 'United States' },
-        { 'name' => 'AirTran Airways', 'iata' => 'FL', 'icao' => 'TRS', 'callsign' => 'CITRUS',
-          'country' => 'United States' },
-        { 'name' => 'U.S. Air', 'iata' => '-+', 'icao' => '--+', 'callsign' => nil, 'country' => 'United States' },
-        { 'name' => 'PanAm World Airways', 'iata' => 'WQ', 'icao' => 'PQW', 'callsign' => nil,
-          'country' => 'United States' },
-        { 'name' => 'Bemidji Airlines', 'iata' => 'CH', 'icao' => 'BMJ', 'callsign' => 'BEMIDJI',
-          'country' => 'United States' }
+        { 'callsign' => 'REUNION', 'country' => 'France', 'iata' => 'UU', 'icao' => 'REU', 'name' => 'Air Austral' },
+        { 'callsign' => 'AIRLINAIR', 'country' => 'France', 'iata' => 'A5', 'icao' => 'RLA', 'name' => 'Airlinair' },
+        { 'callsign' => 'AIRFRANS', 'country' => 'France', 'iata' => 'AF', 'icao' => 'AFR', 'name' => 'Air France' },
+        { 'callsign' => 'AIRCALIN', 'country' => 'France', 'iata' => 'SB', 'icao' => 'ACI',
+          'name' => 'Air Caledonie International' },
+        { 'callsign' => 'T&', 'country' => 'France', 'iata' => '&T', 'icao' => 'T&O',
+          'name' => "Tom's & co airliners" },
+        { 'callsign' => 'BRITAIR', 'country' => 'France', 'iata' => 'DB', 'icao' => 'BZH', 'name' => 'Brit Air' },
+        { 'callsign' => 'Vickjet', 'country' => 'France', 'iata' => 'KT', 'icao' => 'VKJ', 'name' => 'VickJet' },
+        { 'callsign' => 'CORSAIR', 'country' => 'France', 'iata' => 'SS', 'icao' => 'CRL', 'name' => 'Corsairfly' },
+        { 'callsign' => 'CORSICA', 'country' => 'France', 'iata' => 'XK', 'icao' => 'CCM',
+          'name' => 'Corse-Mediterranee' },
+        { 'callsign' => 'AIGLE AZUR', 'country' => 'France', 'iata' => 'ZI', 'icao' => 'AAF', 'name' => 'Aigle Azur' }
       ]
     end
 

test/integration/airports_spec.rb

@@ -192,10 +192,10 @@
   end
 
   describe 'GET /api/v1/airports/direct-connections' do
-    let(:destination_airport_code) { 'JFK' }
+    let(:destination_airport_code) { 'LAX' }
     let(:limit) { 10 }
     let(:offset) { 0 }
-    let(:expected_connections) { %w[DEL LHR EZE ATL CUN MEX LAX SAN SEA SFO] }
+    let(:expected_connections) { %w[NRT CUN GDL HMO MEX MZT PVR SJD ZIH ZLO] }
 
     context 'when the destination airport code is provided' do
       it 'returns the direct connections' do
@@ -213,7 +213,8 @@
         get '/api/v1/airports/direct-connections'
 
         expect(response).to have_http_status(:bad_request)
-        expect(JSON.parse(response.body)).to eq({ 'message' => 'Destination airport code is required' })
+        expect(JSON.parse(response.body)).to eq({ 'error' => 'Invalid request',
+                                                  'message' => 'Destination airport is missing' })
       end
     end
   end