feat: Add new hotel search endpoints and improve error handling

Author: teetangh

app/controllers/api/v1/hotels_controller.rb

@@ -73,13 +73,11 @@ def destroy
       end
 
       def index
-        begin
-          @hotels = Hotel.all
-          formatted_hotels = @hotels.map { |hotel| hotel.attributes.except('id') }
-          render json: formatted_hotels, status: :ok
-        rescue StandardError => e
-          render json: { error: 'Internal server error', message: e.message }, status: :internal_server_error
-        end
+        @hotels = Hotel.all
+        formatted_hotels = @hotels.map { |hotel| hotel.attributes.except('id') }
+        render json: formatted_hotels, status: :ok
+      rescue StandardError => e
+        render json: { error: 'Internal server error', message: e.message }, status: :internal_server_error
       end
 
       def create_with_validations
@@ -107,6 +105,40 @@ def destroy_with_callback
         end
       end
 
+      # GET /hotels/:id
+      def find_hotel_by_id
+        hotel = Hotel.find('hotel_id_123')
+        render json: hotel
+      end
+
+      # GET /hotels/find_by_name
+      def find_hotel_by_name
+        hotel = Hotel.find_by(name: 'Windy Harbour Farm Hotel')
+        render json: hotel
+      end
+
+      # GET /hotels/active_hotels
+      def active_hotels
+        active_hotels = Hotel.where(vacancy: true)
+        formatted_hotels = active_hotels.map { |hotel| hotel.attributes.except('id') }
+        # render just their names and total count
+        render json: { hotels: formatted_hotels.map { |hotel| hotel['name'] }, total: formatted_hotels.count }
+      end
+
+      # GET /hotels/find_by_name_and_price
+      def find_hotels_by_name_and_price
+        hotels = Hotel.where("LOWER(name) LIKE '%hostel%' AND price IS NOT NULL").where(vacancy: true)
+        render json: { hotels: hotels.map { |hotel| hotel.attributes.except('id') }, total: hotels.count }
+      end
+
+      # GET /hotels/find_by_email_domain
+      def find_hotels_by_email_domain
+        hotels = Hotel.where(email: /co.uk/)
+        formatted_hotels = hotels.map { |hotel| hotel.attributes.except('id') }
+        render json: formatted_hotels, status: :ok
+        # render json: { hotels: hotels.map { |hotel| hotel.attributes.except('id') }, total: hotels.count }
+      end
+
       private
 
       def set_hotel

app/models/hotel.rb

@@ -104,10 +104,9 @@ def do_something_after_destroy
   validates :public_likes, exclusion: { in: [nil] }
 
   validate :custom_validation
-  def custom_validation
-    return unless email.include?('rhossilibunkhouse.com')
 
-    errors.add(:email, 'cannot be from rhossilibunkhouse.com')
+  def custom_validation
+    errors.add(:title, 'cannot be funny')
   end
 
   def set_timestamps

config/routes.rb

@@ -28,12 +28,16 @@
       delete 'routes/:id', to: 'routes#destroy'
 
       # Hotel
-      get 'hotels/list', to: 'hotels#index'
-      get 'hotels/:id', to: 'hotels#show'
-      post 'hotels/:id', to: 'hotels#create'
-      put 'hotels/:id', to: 'hotels#update'
-      delete 'hotels/:id', to: 'hotels#destroy'
-
+      # get 'hotels/list', to: 'hotels#index'
+      # get 'hotels/:id', to: 'hotels#show'
+      # post 'hotels/:id', to: 'hotels#create'
+      # put 'hotels/:id', to: 'hotels#update'
+      # delete 'hotels/:id', to: 'hotels#destroy'
+      get 'hotels/find_hotel_by_id', to: 'hotels#find_hotel_by_id'
+      get 'hotels/find_hotel_by_name', to: 'hotels#find_hotel_by_name'
+      get 'hotels/active_hotels', to: 'hotels#active_hotels'
+      get 'hotels/find_by_name_and_price', to: 'hotels#find_hotels_by_name_and_price'
+      get 'hotels/find_by_email_domain', to: 'hotels#find_hotels_by_email_domain'
     end
   end
 end