Refactor controllers to limit the number of records returned in the index action of airlines_controller.rb and airports_controller.rb

Author: teetangh

.gitignore

@@ -4,6 +4,10 @@
 # or operating system, you probably want to add a global ignore instead:
 #   git config --global core.excludesfile '~/.gitignore_global'
 
+
+.vscode/
+.idea/
+
 Gemfile.lock
 
 # Ignore bundler config.

app/controllers/api/v1/airlines_controller.rb

@@ -76,10 +76,71 @@ def destroy
 
       # GET /api/v1/airlines/list
       def index
-        airlines = Airline.all.offset(0).limit(10)
-        render json: airlines.map { |airline| airline.attributes.except('id') }, status: :ok
+        country = params[:country]
+        page = params[:page].to_i || 1
+        per_page = params[:per_page].to_i || 10
+
+        offset = (page - 1) * per_page
+
+        airlines = if country.present?
+                     Airline.where(country:)
+                   else
+                     Airline.all
+                   end
+                   .pluck(:callsign, :country, :iata, :icao, :id, :name)
+        #  .order(:name)
+        #  .offset(offset)
+        #  .limit(per_page)
+
+        formatted_airlines = airlines.map do |airline|
+          {
+            callsign: airline[0],
+            country: airline[1],
+            iata: airline[2],
+            icao: airline[3],
+            id: airline[4],
+            name: airline[5]
+          }
+        end
+
+        render json: formatted_airlines
+      end
+
+      # GET /api/v1/airlines/to-airport
+      def to_airport
+        raise ArgumentError, 'Destination airport is missing' unless params[:destination_airport].present?
+
+        destination_airport = params[:destination_airport]
+        page = params[:page].to_i || 1
+        per_page = params[:per_page].to_i || 10
+
+        offset = (page - 1) * per_page
+
+        airline_ids = Route.where(destinationairport: destination_airport)
+                           #  .distinct(:airlineid)
+                           .pluck(:airlineid)
+
+        airlines = Airline.where(id: airline_ids)
+                          .pluck(:callsign, :country, :iata, :icao, :id, :name)
+        # .offset(offset)
+        # .limit(per_page)
+
+        formatted_airlines = airlines.map do |airline|
+          {
+            callsign: airline[0],
+            country: airline[1],
+            iata: airline[2],
+            icao: airline[3],
+            id: airline[4],
+            name: airline[5]
+          }
+        end
+
+        render json: formatted_airlines
+      rescue ArgumentError => e
+        render json: { error: 'Invalid request', message: e.message }, status: :bad_request
       rescue StandardError => e
-        render json: { error: e.message }, status: :internal_server_error
+        render json: { error: 'Internal server error', message: e.message }, status: :internal_server_error
       end
 
       private

app/controllers/api/v1/airports_controller.rb

@@ -75,10 +75,37 @@ def destroy
 
       # GET /api/v1/airports/list
       def index
-        airports = Airport.pluck(:id, :airportname, :city, :country, :faa, :icao, :tz, :geo)
-        render json: airports
-      rescue StandardError => e
-        render json: { error: e.message }, status: :internal_server_error
+        country = params[:country]
+        page = params[:page].to_i || 1
+        per_page = params[:per_page].to_i || 10
+
+        offset = (page - 1) * per_page
+
+        begin
+          airports = if country.present?
+                       Airport.where(country:)
+                     else
+                       Airport.all
+                     end
+                     .pluck(:airportname, :city, :country, :faa, :geo, :icao, :id, :tz)
+
+          formatted_airports = airports.map do |airport|
+            {
+              airportname: airport[0],
+              city: airport[1],
+              country: airport[2],
+              faa: airport[3],
+              geo: airport[4],
+              icao: airport[5],
+              id: airport[6],
+              tz: airport[7]
+            }
+          end
+
+          render json: formatted_airports
+        rescue StandardError => e
+          render json: { error: 'Internal server error', message: e.message }, status: :internal_server_error
+        end
       end
 
       private

app/models/airline.rb

@@ -12,4 +12,11 @@ class Airline < CouchbaseOrm::Base
   validates :iata, presence: true, length: { is: 2 }
   validates :icao, presence: true, length: { is: 3 }
   validates :country, presence: true
+
+  # Custom N1QL query to list airlines by country with pagination
+  n1ql :by_country, emit_key: :country, query_fn: proc { |bucket, values, options|
+    offset = options.delete(:offset) || 0
+    limit = options.delete(:limit) || 10
+    cluster.query("SELECT * FROM `#{bucket.name}` WHERE type = 'airline' AND country = #{quote(values[0])} ORDER BY name ASC LIMIT #{limit} OFFSET #{offset}", options)
+  }
 end