fix: Address valid Gemini Code Assist feedback

Fixes 4 valid issues identified in PR #8 code review:

1. HIGH PRIORITY - Fixed constant re-assignment in couchbase.rb
   - Changed DB_USERNAME, DB_PASSWORD, DB_CONN_STR to local variables
   - Eliminates Ruby "already initialized constant" warnings
   - Constants at top of file remain for CI environment
   - Local variables used only in dev environment

2. Fixed rswag spec grammar (line 5)
   - Changed "Retrieve suggestion" → "Retrieve suggestions"
   - Matches plural array return type

3. Fixed misleading response description (line 22)
   - Changed "No suggestion" → "List of hotel name suggestions"
   - 200 status should describe success case, not edge case

4. Fixed incorrect response descriptions (lines 73 & 93)
   - Changed "only one Hotels found" → "List of hotels matching the filter criteria"
   - Fixed grammar and made description generic for filter endpoint

Note: Rejected Gemini's metaprogramming suggestion for search index
assignment as it adds unnecessary complexity without benefit.

Regenerated swagger.yaml from updated rswag specs.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: teetangh

config/initializers/couchbase.rb

@@ -23,15 +23,15 @@
     DEFAULT_DB_PASSWORD = 'password'
     DEFAULT_DB_CONN_STR = 'couchbase://localhost'
 
-    # Get environment variables with fallback to default values
-    DB_USERNAME = ENV.fetch('DB_USERNAME', DEFAULT_DB_USERNAME)
-    DB_PASSWORD = ENV.fetch('DB_PASSWORD', DEFAULT_DB_PASSWORD)
-    DB_CONN_STR = ENV.fetch('DB_CONN_STR', DEFAULT_DB_CONN_STR)
+    # Get environment variables with fallback to default values (using local variables)
+    db_username = ENV.fetch('DB_USERNAME', DEFAULT_DB_USERNAME)
+    db_password = ENV.fetch('DB_PASSWORD', DEFAULT_DB_PASSWORD)
+    db_conn_str = ENV.fetch('DB_CONN_STR', DEFAULT_DB_CONN_STR)
 
     # Connect to the Couchbase cluster
     options = Couchbase::Cluster::ClusterOptions.new
-    options.authenticate(DB_USERNAME, DB_PASSWORD)
-    COUCHBASE_CLUSTER = Couchbase::Cluster.connect(DB_CONN_STR, options)
+    options.authenticate(db_username, db_password)
+    COUCHBASE_CLUSTER = Couchbase::Cluster.connect(db_conn_str, options)
   end
 
   # Open the bucket

spec/requests/api/v1/hotels_spec.rb

@@ -2,7 +2,7 @@
 
 describe 'Hotels API', type: :request do
   path '/api/v1/hotels/autocomplete' do
-    get 'Retrieve suggestion for Hotel names' do
+    get 'Retrieve suggestions for Hotel names' do
       tags 'Hotels'
       produces 'application/json'
       parameter name: :name, in: :query, type: :string, description: 'name of the hotel'
@@ -19,7 +19,7 @@
         end
       end
 
-      response '200', 'No suggestion' do
+      response '200', 'List of hotel name suggestions' do
         schema type: :Array,
                items: {
                  type: :string
@@ -70,7 +70,7 @@
           expect(data.length()).to be >(0)
         end
       end
-      response '200', 'only one Hotels found' do
+      response '200', 'List of hotels matching the filter criteria' do
         schema type: :Array,
                items: {
                  type: :object,
@@ -90,7 +90,7 @@
           expect(data.length()).to eq(1)
         end
       end
-      response '200', 'only one Hotels found' do
+      response '200', 'List of hotels matching the filter criteria' do
         schema type: :Array,
                items: {
                  type: :object,

swagger/v1/swagger.yaml

@@ -443,7 +443,7 @@ paths:
           description: bad request
   "/api/v1/hotels/autocomplete":
     get:
-      summary: Retrieve suggestion for Hotel names
+      summary: Retrieve suggestions for Hotel names
       tags:
       - Hotels
       parameters:
@@ -454,7 +454,7 @@ paths:
           type: string
       responses:
         '200':
-          description: No suggestion
+          description: List of hotel name suggestions
           content:
             application/json:
               schema:
@@ -469,7 +469,7 @@ paths:
       parameters: []
       responses:
         '200':
-          description: only one Hotels found
+          description: List of hotels matching the filter criteria
           content:
             application/json:
               schema: