MB-60786: Vector search will not be supported in a mixed cluster

+ We already accounted for the situation where a user does
  a rolling online upgrade from pre-7.6 to 7.6.
+ This fix will address the situation where the user upgrades
  from CE to EE.

Change-Id: I41193b40015fd3ad729387deeb68a88605836fbf
Reviewed-on: https://review.couchbase.org/c/cbft/+/205688
Well-Formed: Restriction Checker
Well-Formed: Build Bot <[email protected]>
Tested-by: Abhi Dangeti <[email protected]>
Reviewed-by: Abhi Dangeti <[email protected]>

Author: abhinavdangeti

cmd/cbft/main.go

@@ -342,7 +342,7 @@ func mainStart(cfg cbgt.Cfg, uuid string, tags []string, container string,
 		"," + cbft.FeatureBlevePreferredSegmentVersion +
 		"," + cbft.FeatureFileTransferRebalance +
 		"," + cbft.FeatureGeoSpatial +
-		"," + cbft.FeatureVectorSupportVersion
+		cbft.FeatureVectorSearchSupport()
 
 	extrasMap["version-cbft.app"] = version
 	extrasMap["version-cbft.lib"] = cbft.VERSION

knn_nosup.go

@@ -17,6 +17,12 @@ import (
 	"github.com/blevesearch/bleve/v2"
 )
 
+func FeatureVectorSearchSupport() string {
+	return ""
+}
+
+// -----------------------------------------------------------------------------
+
 func interpretKNNForRequest(knn, knnOperator json.RawMessage, r *bleve.SearchRequest) (
 	*bleve.SearchRequest, error) {
 	// Not supported

knn_sup.go

@@ -17,6 +17,12 @@ import (
 	"github.com/blevesearch/bleve/v2"
 )
 
+func FeatureVectorSearchSupport() string {
+	return "," + FeatureVectorSearch
+}
+
+// -----------------------------------------------------------------------------
+
 func interpretKNNForRequest(knn, knnOperator json.RawMessage, r *bleve.SearchRequest) (
 	*bleve.SearchRequest, error) {
 	if knn != nil && r != nil {

pindex_bleve.go

@@ -61,6 +61,8 @@ var FeatureCollections = cbgt.SOURCE_GOCBCORE + ":collections"
 
 var FeatureGeoSpatial = "geoSpatial"
 
+var FeatureVectorSearch = "vectors"
+
 var FeatureBlevePreferredSegmentVersion = fmt.Sprintf("segmentVersion:%d", BlevePreferredZapVersion)
 
 var BleveMaxOpsPerBatch = 200 // Unlimited when <= 0.
@@ -537,6 +539,8 @@ func PrepareIndexDef(mgr *cbgt.Manager, indexDef *cbgt.IndexDef) (
 		indexDef.SourceType = cbgt.SOURCE_GOCBCORE
 	}
 
+	var vectorFieldsSpecifiedInMapping bool
+
 	bp := NewBleveParams()
 	if len(indexDef.Params) > 0 {
 		b, err := bleveMappingUI.CleanseJSON([]byte(indexDef.Params))
@@ -608,10 +612,12 @@ func PrepareIndexDef(mgr *cbgt.Manager, indexDef *cbgt.IndexDef) (
 			}
 		}
 
-		if !isClusterCompatibleFor(FeatureVectorSupportVersion) {
+		vectorFieldsSpecifiedInMapping = vectorFieldsExistWithinIndexMapping(bp.Mapping)
+		if !isClusterCompatibleFor(FeatureVectorSearchSupportVersion) ||
+			!cbgt.IsFeatureSupportedByCluster(FeatureVectorSearch, nodeDefs) {
 			// Vector indexing & search is NOT supported on this cluster
 			// (lower version or mixed lower version)
-			if vectorFieldsExistWithinIndexMapping(bp.Mapping) {
+			if vectorFieldsSpecifiedInMapping {
 				return nil, cbgt.NewBadRequestError("PrepareIndex, err: vector typed fields " +
 					"not supported in mixed version cluster")
 			}
@@ -634,7 +640,7 @@ func PrepareIndexDef(mgr *cbgt.Manager, indexDef *cbgt.IndexDef) (
 					"supported", int(zv))
 			}
 
-			if vectorFieldsExistWithinIndexMapping(bp.Mapping) && int(zv) < BleveVectorZapVersion {
+			if vectorFieldsSpecifiedInMapping && int(zv) < BleveVectorZapVersion {
 				// overrride segmentVersion to minimum version needed to support vector mappings
 				bp.Store["segmentVersion"] = BleveVectorZapVersion
 			}
@@ -647,7 +653,7 @@ func PrepareIndexDef(mgr *cbgt.Manager, indexDef *cbgt.IndexDef) (
 		// zap version for newer indexes in a sufficiently advanced
 		// cluster, else consider the default zap version.
 		if segmentVersionSupported {
-			if vectorFieldsExistWithinIndexMapping(bp.Mapping) {
+			if vectorFieldsSpecifiedInMapping {
 				bp.Store["segmentVersion"] = BleveVectorZapVersion
 			} else {
 				bp.Store["segmentVersion"] = BlevePreferredZapVersion

version.go

@@ -45,7 +45,7 @@ const FeatureGrpcVersion = "6.5.0"
 
 const FeatureScopedIndexNamesVersion = "7.5.0"
 
-const FeatureVectorSupportVersion = "7.6.0"
+const FeatureVectorSearchSupportVersion = "7.6.0"
 
 func HandleAPIVersion(h string) (string, error) {
 	if len(h) <= 0 || h == "*/*" {