JCBC-2146 fix for lock duration when specified as sub-second rounds to 0

Issue :-
	When a lock duration is specified in sub-second units, the fractional part is lost during conversion to the binary protocol format, resulting in the lock duration being effectively rounded down to zero

Fix :-
        To address the issue of sub-second lock durations being ignored, the fix involves rounding up the lock duration to the nearest whole second whenever fractional seconds (milliseconds, nanoseconds) are present. This ensures that the lock is held for at least one second, even if the specified duration is less than a full second.

Change-Id: Id16cb52d6233a8011b0dc30a175038ab0aa586a2
Reviewed-on: https://review.couchbase.org/c/couchbase-jvm-clients/+/227612
Reviewed-by: David Nault <[email protected]>
Tested-by: Build Bot <[email protected]>

Author: CosmicSaaurabh

core-io/src/main/java/com/couchbase/client/core/msg/kv/GetAndLockRequest.java

@@ -27,7 +27,7 @@
 import com.couchbase.client.core.retry.RetryStrategy;
 import com.couchbase.client.core.deps.io.netty.buffer.ByteBuf;
 import com.couchbase.client.core.deps.io.netty.buffer.ByteBufAllocator;
-import com.couchbase.client.core.util.Bytes;
+import com.couchbase.client.core.util.CbDurations;
 
 import java.time.Duration;
 
@@ -60,7 +60,8 @@ public ByteBuf encode(ByteBufAllocator alloc, int opaque, KeyValueChannelContext
 
     try {
       key = encodedKeyWithCollection(alloc, ctx);
-      extras = alloc.buffer(Integer.BYTES).writeInt((int) lockFor.getSeconds());
+      long secondsToLock = CbDurations.getSecondsCeil(lockFor);
+      extras = alloc.buffer(Integer.BYTES).writeInt(Math.toIntExact(secondsToLock));
 
       return MemcacheProtocol.request(alloc, Opcode.GET_AND_LOCK, noDatatype(),
         partition(), opaque, noCas(), extras, key, noBody());

core-io/src/main/java/com/couchbase/client/core/util/CbDurations.java

@@ -0,0 +1,39 @@
+/*
+ * Copyright (c) 2025 Couchbase, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *    https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.couchbase.client.core.util;
+
+import com.couchbase.client.core.annotation.Stability;
+
+import java.time.Duration;
+
+@Stability.Internal
+public final class CbDurations {
+  private CbDurations() {
+
+  }
+
+  /**
+   * Converts a Duration to seconds, rounding up if there are any partial seconds.
+   * @param duration the duration to convert
+   * @return the duration in seconds, rounded up if there are any partial seconds
+   */
+  public static long getSecondsCeil(final Duration duration) {
+    return duration.getNano() == 0
+      ? duration.getSeconds()
+      : Math.addExact(duration.getSeconds(), 1L);
+  }
+}

core-io/src/test/java/com/couchbase/client/core/util/CbDurationsTest.java

@@ -0,0 +1,37 @@
+package com.couchbase.client.core.util;
+
+import org.junit.jupiter.api.Test;
+
+import java.time.Duration;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
+
+public class CbDurationsTest {
+
+  @Test
+  void shouldReturnSameValueForWholeSeconds() {
+    assertEquals(0, CbDurations.getSecondsCeil(Duration.ZERO));
+    assertEquals(1, CbDurations.getSecondsCeil(Duration.ofSeconds(1)));
+    assertEquals(5, CbDurations.getSecondsCeil(Duration.ofSeconds(5)));
+    assertEquals(Integer.MAX_VALUE,
+      CbDurations.getSecondsCeil(Duration.ofSeconds(Integer.MAX_VALUE)));
+  }
+
+  @Test
+  void shouldRoundUpForPartialSeconds() {
+    assertEquals(1, CbDurations.getSecondsCeil(Duration.ofMillis(1)));
+    assertEquals(1, CbDurations.getSecondsCeil(Duration.ofMillis(999)));
+    assertEquals(2, CbDurations.getSecondsCeil(Duration.ofMillis(1001)));
+    assertEquals(2, CbDurations.getSecondsCeil(Duration.ofNanos(1_000_000_001)));
+  }
+
+  @Test
+  void shouldHandleMixedValues() {
+    assertEquals(3, CbDurations.getSecondsCeil(
+      Duration.ofSeconds(2).plusMillis(500)));
+    assertEquals(3, CbDurations.getSecondsCeil(
+      Duration.ofSeconds(2).plusNanos(1)));
+  }
+}