TestFix: KeyValueCollectionIntegrationTest.recognizesCollectionAfterCreation

Motivation
----------
This test was failing against Community Edition
because it used the deprecated createCollection(CollectionSpec)
method which sends the enterprise-only `maxTTL` parameter
regardless of whether the caller specified it.

Modifications
-------------
Update the deprecation warning to indicate the method
is not compatible with Community Edition.

Update the test to use the non-deprecated version
of `createCollection`, which works with CE.

Rejected Alternatives
---------------------
We _could_ change the deprecated method
to convert a zero TTL into null so it wouldn't
get sent to the server. However, this would ignore
a zero TTL explicitly set by the user, breaking
the behavior if the server's default TTL ever changes
to something other than zero.

Change-Id: I3fac794436b71254b68bcf39ec444702493a2a87
Reviewed-on: https://review.couchbase.org/c/couchbase-jvm-clients/+/228634
Reviewed-by: Will Broadbelt <[email protected]>
Tested-by: Build Bot <[email protected]>

Author: dnault

java-client/src/integrationTest/java/com/couchbase/client/java/KeyValueCollectionIntegrationTest.java

@@ -60,12 +60,12 @@ static void afterAll() {
   @Test
   @IgnoreWhen(isProtostellarWillWorkLater = true) // Fails as CNG is not yet waiting for the collection to be ready before continuing
   void recognizesCollectionAfterCreation() {
-    String collId = UUID.randomUUID().toString().substring(0, 10);
-    CollectionSpec collectionSpec = CollectionSpec.create(collId, DEFAULT_SCOPE);
-    bucket.collections().createCollection(collectionSpec);
-    if (!config().isProtostellar()) ConsistencyUtil.waitUntilCollectionPresent(cluster.core(), bucket.name(), collectionSpec.scopeName(), collectionSpec.name());
+    String collectionName = UUID.randomUUID().toString().substring(0, 10);
+    String scopeName = DEFAULT_SCOPE;
+    bucket.collections().createCollection(scopeName, collectionName);
+    if (!config().isProtostellar()) ConsistencyUtil.waitUntilCollectionPresent(cluster.core(), bucket.name(), scopeName, collectionName);
 
-    Collection collection = bucket.collection(collId);
+    Collection collection = bucket.collection(collectionName);
 
     String id = UUID.randomUUID().toString();
     String content = "bar";
@@ -75,7 +75,7 @@ void recognizesCollectionAfterCreation() {
     assertEquals(upsertResult.cas(), getResult.cas());
     assertEquals(content, getResult.contentAs(String.class));
 
-    checkCachesScopesAndCollections(bucket.async(), collId);
+    checkCachesScopesAndCollections(bucket.async(), collectionName);
   }
 
   private void checkCachesScopesAndCollections(AsyncBucket bucket, String collId) {

java-client/src/main/java/com/couchbase/client/java/manager/collection/AsyncCollectionManager.java

@@ -85,6 +85,7 @@ public AsyncCollectionManager(
    * @throws ScopeNotFoundException (async) if the specified scope does not exist.
    * @throws CouchbaseException (async) if any other generic unhandled/unexpected errors.
    * @deprecated This method cannot be used to set the collection's "history" property.
+   * This method is not compatible with Couchbase Server Community Edition.
    * Please use {@link #createCollection(String, String, CreateCollectionSettings)} instead.
    */
   @Deprecated
@@ -104,6 +105,7 @@ public CompletableFuture<Void> createCollection(final CollectionSpec collectionS
    * @throws ScopeNotFoundException (async) if the specified scope does not exist.
    * @throws CouchbaseException (async) if any other generic unhandled/unexpected errors.
    * @deprecated This method cannot be used to set the collection's "history" property.
+   * This method is not compatible with Couchbase Server Community Edition.
    * Please use {@link #createCollection(String, String, CreateCollectionSettings, CreateCollectionOptions)} instead.
    */
   @Deprecated

java-client/src/main/java/com/couchbase/client/java/manager/collection/CollectionManager.java

@@ -70,6 +70,7 @@ public CollectionManager(final AsyncCollectionManager async) {
    * @throws ScopeNotFoundException if the specified scope does not exist.
    * @throws CouchbaseException if any other generic unhandled/unexpected errors.
    * @deprecated This method cannot be used to set the collection's "history" property.
+   * This method is not compatible with Couchbase Server Community Edition.
    * Please use {@link #createCollection(String, String, CreateCollectionSettings)} instead.
    */
   @Deprecated
@@ -89,6 +90,7 @@ public void createCollection(final CollectionSpec collectionSpec) {
    * @throws CouchbaseException if any other generic unhandled/unexpected errors.
    *
    * @deprecated This method cannot be used to set the collection's "history" property.
+   * This method is not compatible with Couchbase Server Community Edition.
    * Please use {@link #createCollection(String, String, CreateCollectionSettings, CreateCollectionOptions)} instead.
    */
   @Deprecated

java-client/src/main/java/com/couchbase/client/java/manager/collection/ReactiveCollectionManager.java

@@ -74,6 +74,7 @@ public ReactiveCollectionManager(final ReactorOps reactor, final AsyncCollection
    * @throws ScopeNotFoundException (async) if the specified scope does not exist.
    * @throws CouchbaseException (async) if any other generic unhandled/unexpected errors.
    * @deprecated This method cannot be used to set the collection's "history" property.
+   * This method is not compatible with Couchbase Server Community Edition.
    * Please use {@link #createCollection(String, String, CreateCollectionSettings)} instead.
    */
   @Deprecated
@@ -93,6 +94,7 @@ public Mono<Void> createCollection(final CollectionSpec collectionSpec) {
    * @throws ScopeNotFoundException (async) if the specified scope does not exist.
    * @throws CouchbaseException (async) if any other generic unhandled/unexpected errors.
    * @deprecated This method cannot be used to set the collection's "history" property.
+   * This method is not compatible with Couchbase Server Community Edition.
    * Please use {@link #createCollection(String, String, CreateCollectionSettings, CreateCollectionOptions)} instead.
    */
   @Deprecated