Expose Log.log for RN testing #3475
Open
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
will port to 4.0 once merged |
pasin
reviewed
Nov 5, 2025
Contributor
pasin
left a comment
pasin
left a comment
There was a problem hiding this comment.
I think we should do .log() instead of ._log() as it is also used by our own code. The _getRevisionHistory() is a bit different as we don’t actually used it at all, but when looking at at now, it’s not necessarily to do _ as we have clearly said that it’s unsupported.
pasin
reviewed
Nov 6, 2025
Swift/Log.swift
Outdated
| /// Writes a log message to all the enabled log sinks. | ||
| internal static func log(domain: LogDomain, level: LogLevel, message: String) { | ||
| /// - Note: `Unsupported API` Internal used for testing purpose. | ||
| static func log(domain: LogDomain, level: LogLevel, message: String) { |
velicuvlad
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.issues.couchbase.com/browse/CBL-7613