Fix minitest on CI

Author: avsej

.github/workflows/tests.yml

@@ -26,6 +26,10 @@ jobs:
           submodules: recursive
           fetch-depth: 0
           fetch-tags: true
+      - name: Install dependencies
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y pkgconfig libcurl4-openssl-dev
       - uses: ruby/setup-ruby@v1
         with:
           ruby-version: 3.3
@@ -109,6 +113,7 @@ jobs:
             make \
             openssl \
             openssl-dev \
+            curl-dev \
             readline-dev \
             ruby \
             tar \
@@ -555,6 +560,15 @@ jobs:
             logs/*
             test/**/*.{log,xml}
           retention-days: 5
+      - name: Upload crash logs
+        if: failure()
+        uses: actions/upload-artifact@v4
+        with:
+          name: ${{ github.job }}-${{ github.run_attempt }}-${{ matrix.ruby }}-crash
+          path: |
+            ~/Library/Logs/DiagnosticReports/
+            /Library/Logs/DiagnosticReports/
+          retention-days: 5
       - name: Publish Test Report
         uses: mikepenz/[email protected]
         if: always()
@@ -616,6 +630,15 @@ jobs:
             logs/*
             test/**/*.{log,xml}
           retention-days: 5
+      - name: Upload crash logs
+        if: failure()
+        uses: actions/upload-artifact@v4
+        with:
+          name: ${{ github.job }}-${{ github.run_attempt }}-${{ matrix.ruby }}-crash
+          path: |
+            ~/Library/Logs/DiagnosticReports/
+            /Library/Logs/DiagnosticReports/
+          retention-days: 5
       - name: Publish Test Report
         uses: mikepenz/[email protected]
         if: always()

.gitignore

@@ -18,6 +18,7 @@
 /pkg/
 /test/reports/
 /tmp/
+/logs/
 /vendor/bundle/
 Gemfile.lock
 Makefile

Gemfile

@@ -23,14 +23,15 @@ gem "rake"
 
 group :development do
   gem "activesupport", "~> 7.0.3"
+  gem "curb"
   gem "drb"
   gem "faker"
   gem "flay"
   gem "flog"
   gem "gem-compiler"
   gem "grpc-tools", "~> 1.59"
   gem "heckle"
-  gem "minitest"
+  gem "minitest", "< 6.0"
   gem "minitest-reporters"
   gem "mutex_m"
   gem "rack"
@@ -44,15 +45,4 @@ group :development do
   gem "ruby-lsp", require: false
   gem "simplecov-cobertura"
   gem "yard"
-
-  # Resolves https://github.com/ruby/openssl/issues/949 which we encounter when downloading gocaves on macOS on CI
-  # This has been fixed in openssl versions 3.1.2, 3.2.2, 3.3.1.
-  # The latest dot-patch version of Ruby 3.3 and 3.4 now comes with a new enough openssl version by default.
-  if RUBY_PLATFORM.include?("darwin")
-    if RUBY_VERSION.start_with?('3.2')
-      gem "openssl", "~> 3.2.2"
-    elsif RUBY_VERSION.start_with?('3.1')
-      gem "openssl", "~> 3.1.2"
-    end
-  end
 end

test/mock_helper.rb

@@ -20,30 +20,33 @@
 require "fileutils"
 require "tmpdir"
 require "socket"
+require "curb"
 
 class Caves
   attr_accessor :verbose
 
-  VERSION = "v0.0.1-78"
+  VERSION = "v0.0.1-79"
   FORK = "couchbaselabs"
 
   def download_mock(url = caves_url)
     return if binary_ready?
 
     puts "download #{url}"
-    resp = Net::HTTP.get_response(URI.parse(url))
 
-    case resp
-    when Net::HTTPSuccess
-      raise "Unexpected content type: #{resp['content-type']}" if resp["content-type"] != "application/octet-stream"
+    curl = Curl::Easy.new(url) do |c|
+      c.follow_location = true
+      c.max_redirects = 5
+    end
+    curl.perform
 
+    case curl.response_code
+    when 200..299
+      raise "Unexpected content type: #{curl.content_type}" if curl.content_type != "application/octet-stream"
       FileUtils.mkdir_p(caves_dir, verbose: verbose?)
-      File.write(mock_path, resp.body, binmode: true)
+      File.write(mock_path, curl.body, binmode: true)
       FileUtils.chmod("a+x", mock_path, verbose: verbose?) unless windows?
-    when Net::HTTPRedirection
-      download_mock(resp["location"])
     else
-      raise "Unable to download mock from #{url}: #{resp.status}"
+      raise "Unable to download mock from #{url}: #{curl.response_code}"
     end
   end