Merge branch 'release/3.4' into DOC-10989

Author: tom-rosewell

modules/howtos/examples/Analytics.java

@@ -17,7 +17,7 @@
  /*
   * You need the following datasets created:
   *
-  *  CREATE DATASET `airports` ON `travel-sample` where `type` = "airport";
+  *  CREATE DATASET `airport` ON `travel-sample` where `type` = "airport";
   *  CREATE DATASET `huge-dataset` ON `travel-sample`;
   *  ALTER COLLECTION `travel-sample`.`inventory`.`airport` ENABLE ANALYTICS;
   *  CONNECT LINK Local;
@@ -86,7 +86,7 @@ public static void main(String... args) {
     {
       // tag::named[]
       AnalyticsResult result = cluster.analyticsQuery(
-        "select count(*) from airports where country = $country",
+        "select count(*) from airport where country = $country",
         analyticsOptions().parameters(JsonObject.create().put("country", "France")));
       // end::named[]
       show("named", result);
@@ -95,7 +95,7 @@ public static void main(String... args) {
     {
       // tag::positional[]
       AnalyticsResult result = cluster.analyticsQuery(
-        "select count(*) from airports where country = ?",
+        "select count(*) from airport where country = ?",
         analyticsOptions().parameters(JsonArray.from("France"))
       );
       // end::positional[]
@@ -105,7 +105,7 @@ public static void main(String... args) {
     {
       // tag::scanconsistency[]
       AnalyticsResult result = cluster.analyticsQuery(
-        "select count(*) from airports where country = 'France'",
+        "select count(*) from airport where country = 'France'",
         analyticsOptions().scanConsistency(AnalyticsScanConsistency.REQUEST_PLUS)
       );
       // end::scanconsistency[]
@@ -115,7 +115,7 @@ public static void main(String... args) {
     {
       // tag::clientcontextid[]
       AnalyticsResult result = cluster.analyticsQuery(
-        "select count(*) from airports where country = 'France'",
+        "select count(*) from airport where country = 'France'",
         analyticsOptions().clientContextId("user-44" + UUID.randomUUID())
       );
       // end::clientcontextid[]
@@ -125,7 +125,7 @@ public static void main(String... args) {
     {
       // tag::priority[]
       AnalyticsResult result = cluster.analyticsQuery(
-        "select count(*) from airports where country = 'France'",
+        "select count(*) from airport where country = 'France'",
         analyticsOptions().priority(true)
       );
       // end::priority[]
@@ -135,7 +135,7 @@ public static void main(String... args) {
     {
       // tag::readonly[]
       AnalyticsResult result = cluster.analyticsQuery(
-        "select count(*) from airports where country = 'France'",
+        "select count(*) from airport where country = 'France'",
         analyticsOptions().readonly(true)
       );
       // end::readonly[]
@@ -154,7 +154,7 @@ public static void main(String... args) {
     {
       // tag::rowsasobject[]
       AnalyticsResult result = cluster.analyticsQuery(
-        "select * from airports limit 3"
+        "select * from airport limit 3"
       );
       for (JsonObject row : result.rowsAsObject()) {
         System.out.println("Found row: " + row);

modules/project-docs/pages/sdk-full-installation.adoc

@@ -43,18 +43,17 @@ You can use your favorite dependency management tool to install the SDK.
 Maven::
 +
 --
-The following snippet shows how to do it with https://maven.apache.org/[Maven].
+For https://maven.apache.org[Maven], you can insert the following into the dependencies section of your project's `pom.xml` file:
 
 [source,xml]
 ----
-<dependencies>
     <dependency>
         <groupId>com.couchbase.client</groupId>
         <artifactId>java-client</artifactId>
         <version>3.4.4</version>
     </dependency>
-</dependencies>
 ----
+Refer to the https://maven.apache.org/guides/introduction/introduction-to-the-pom.html/[Maven Documentation] for more information regarding the structure of the `pom.xml` file.
 --
 Gradle::
 +

modules/project-docs/pages/sdk-release-notes.adoc

@@ -219,6 +219,12 @@ The SDK no longer rejects a `PersistTo` requirement in a bucket using the Magma
 If you call `CancellationErrorContext.getWaitUntilReadyContext()` on an error context that didn't come from a "wait until ready" request, the method is now guaranteed to return null instead of sometimes throwing a `ClassCastException`.
 * https://issues.couchbase.com/browse/JCBC-2024[JCBC-2024]:
 Fixed a memory leak in ManagerMessageHandler.
+* https://issues.couchbase.com/browse/JVMCBC-1247[JVMCBC-1247]:
+The SDK now throws `InvalidArgumentException: Failed to parse connection string` if the connection string has a syntax error.
+For example, the following connection string is malformed, because the `couchbase://` part is repeated:
+`couchbase://foo.example.com,couchbase://bar.example.com`.
+The correct way to include multiple addresses in a connection string is to specify the scheme only once, and to join addresses with commas, like:
+`couchbase://foo.example.com,bar.example.com`
 
 == Version 3.4.0 (24 October 2022)
 

modules/test/scripts/init-couchbase/init-buckets.sh

@@ -1,5 +1,14 @@
 #!/bin/bash
 
+# ===============================================
+# NOTE: Any changes made to this file will not be 
+# automatically reflected in `make cb-start` as
+# the Makefile does not use the mounted version
+# of this file in the Docker image. You will need
+# to rebuild the image via `make cb-build` before
+# running `make cb-start`.
+# ===============================================
+
 # exit immediately if a command fails or if there are unset vars
 set -euo pipefail
 
@@ -32,9 +41,9 @@ echo "cbimport travel-sample..."
     -b travel-sample \
     -d file:///opt/couchbase/samples/travel-sample.zip
 
-echo "create airports dataset"
+echo "create airport dataset"
 curl --fail -v -u ${CB_USER}:${CB_PSWD} -H "Content-Type: application/json" -d '{
-    "statement": "CREATE DATASET airports ON `travel-sample` WHERE `type`=\"airport\";",
+    "statement": "CREATE DATASET airport ON `travel-sample` WHERE `type`=\"airport\";",
     "pretty":true,
     "client_context_id":"test"
 }' http://${CB_HOST}:8095/analytics/service

modules/test/scripts/init-couchbase/init.sh

@@ -1,5 +1,14 @@
 #!/bin/bash
 
+# ===============================================
+# NOTE: Any changes made to this file will not be 
+# automatically reflected in `make cb-start` as
+# the Makefile does not use the mounted version
+# of this file in the Docker image. You will need
+# to rebuild the image via `make cb-build` before
+# running `make cb-start`.
+# ===============================================
+
 CB_USER="${CB_USER:-Administrator}"
 CB_PSWD="${CB_PSWD:-password}"
 CB_HOST="${CB_HOST:-127.0.0.1}"