C++20 use std::memory_order<type>

the values in std::memory_order is no longer available

Change-Id: Ic0423cc0bc3314047b7085dbcf801eb06251590e
Reviewed-on: https://review.couchbase.org/c/kv_engine/+/189931
Tested-by: Build Bot <[email protected]>
Reviewed-by: James H <[email protected]>

Author: trondn

daemon/connection.cc

@@ -270,15 +270,15 @@ void Connection::updatePrivilegeContext() {
     subject_to_metering.store(
             privilegeContext.check(cb::rbac::Privilege::Unmetered, {}, {})
                     .failed(),
-            std::memory_order::memory_order_release);
+            std::memory_order_release);
     subject_to_throttling.store(
             privilegeContext.check(cb::rbac::Privilege::Unthrottled, {}, {})
                     .failed(),
-            std::memory_order::memory_order_release);
+            std::memory_order_release);
     node_supervisor.store(
             privilegeContext.check(cb::rbac::Privilege::NodeSupervisor, {}, {})
                     .success(),
-            std::memory_order::memory_order_release);
+            std::memory_order_release);
 }
 
 cb::engine_errc Connection::dropPrivilege(cb::rbac::Privilege privilege) {

daemon/connection.h

@@ -817,8 +817,7 @@ class Connection : public ConnectionIface,
     }
 
     bool isSubjectToMetering() const {
-        return subject_to_metering.load(
-                std::memory_order::memory_order_acquire);
+        return subject_to_metering.load(std::memory_order_acquire);
     }
 
     /// Is this connection not to be throttled?
@@ -827,25 +826,22 @@ class Connection : public ConnectionIface,
     }
 
     bool isSubjectToThrottling() const {
-        return subject_to_throttling.load(
-                std::memory_order::memory_order_acquire);
+        return subject_to_throttling.load(std::memory_order_acquire);
     }
 
     bool isNodeSupervisor() const {
-        return node_supervisor.load(std::memory_order::memory_order_acquire);
+        return node_supervisor.load(std::memory_order_acquire);
     }
 
     /// Clear the DCP throttle for this connection to allow it to progress
     void resumeThrottledDcpStream();
 
     bool isNonBlockingThrottlingMode() const {
-        return non_blocking_throttling_mode.load(
-                std::memory_order::memory_order_acquire);
+        return non_blocking_throttling_mode.load(std::memory_order_acquire);
     }
 
     void setNonBlockingThrottlingMode(bool enable) {
-        non_blocking_throttling_mode.store(enable,
-                std::memory_order::memory_order_release);
+        non_blocking_throttling_mode.store(enable, std::memory_order_release);
     }
 
     /**

daemon/stats.h

@@ -167,14 +167,14 @@ struct stats {
     std::atomic<unsigned int> curr_conns;
 
     size_t getCurrConnections() const {
-        return curr_conns.load(std::memory_order::memory_order_consume);
+        return curr_conns.load(std::memory_order_consume);
     }
 
     /// The number of system connections
     std::atomic<unsigned int> system_conns;
 
     size_t getSystemConnections() const {
-        return system_conns.load(std::memory_order::memory_order_consume);
+        return system_conns.load(std::memory_order_consume);
     }
 
     size_t getUserConnections() const {