CBD-6348: [BP] Various fixes needed to build with C++20

Various small fixes needed to build in C++20 mode with the new
MSVC compiler.

Change-Id: Iad203ee3df7905f014f46f2e5254984e4fe678d8
Reviewed-on: https://review.couchbase.org/c/kv_engine/+/234993
Well-Formed: Restriction Checker
Tested-by: Trond Norbye <[email protected]>
Reviewed-by: Mohammad Zaeem <[email protected]>

Author: trondn

engines/ep/src/collections/kvstore.cc

@@ -30,7 +30,7 @@ void verifyFlatbuffersData(cb::const_byte_buffer buf,
         return;
     }
     throw std::runtime_error(fmt::format(
-            "verifyFlatbuffersData:{} data invalid, ptr:{}, size:{:p}",
+            "verifyFlatbuffersData:{} data invalid, ptr:{}, size:{}",
             caller,
             fmt::ptr(buf.data()),
             buf.size()));

engines/ep/src/kvstore/nexus-kvstore/nexus-kvstore.cc

@@ -3070,7 +3070,7 @@ GetValue NexusKVStore::getBySeqno(KVFileHandle& handle,
     if (primaryGetValue.getStatus() == cb::engine_errc::success &&
         !compareItem(*primaryGetValue.item, *secondaryGetValue.item)) {
         auto msg = fmt::format(
-                "NexusKVStore::{}: {} seqno:{} item mismatch primary:{} "
+                "NexusKVStore::getBySeqno: {} seqno:{} item mismatch primary:{} "
                 "secondary:{}",
                 vbid,
                 seq,

engines/ep/src/mutation_log.cc

@@ -323,7 +323,7 @@ MutationLog::~MutationLog() {
 }
 
 void MutationLog::disable() {
-    if (file >= 0) {
+    if (file >= INVALID_FILE_VALUE) {
         close();
         disabled = true;
     }

programs/mctimings/mctimings.cc

@@ -586,7 +586,7 @@ int main(int argc, char** argv) {
 
     if (!file.empty()) {
         try {
-            fmt::print(stdout, histogramInfo);
+            fmt::print(stdout, "{}", histogramInfo);
             dumpHistogramFromFile(file);
         } catch (const std::exception& ex) {
             fmt::print(stderr, "{}\n", ex.what());
@@ -630,7 +630,7 @@ int main(int argc, char** argv) {
         }
 
         if (verbose && !json) {
-            fmt::print(stdout, histogramInfo);
+            fmt::print(stdout, "{}", histogramInfo);
         }
 
         if (buckets.empty()) {