MB-43205: Remove DcpConsumer::engine

The ConnHandler base class has it already, just use that.

Change-Id: I2ee8b2973f0cfa1bd6ca295e0deb9348cbde6045
Reviewed-on: http://review.couchbase.org/c/kv_engine/+/143659
Reviewed-by: Trond Norbye <[email protected]>
Tested-by: Build Bot <[email protected]>
Well-Formed: Build Bot <[email protected]>

Author: paolococchi

engines/ep/src/dcp/consumer.cc

@@ -153,7 +153,6 @@ DcpConsumer::DcpConsumer(EventuallyPersistentEngine& engine,
                          const std::string& consumerName_)
     : ConnHandler(engine, cookie, name),
       lastMessageTime(ep_current_time()),
-      engine(engine),
       opaqueCounter(0),
       processorTaskId(0),
       processorTaskState(all_processed),
@@ -308,7 +307,7 @@ ENGINE_ERROR_CODE DcpConsumer::addStream(uint32_t opaque,
     bool exp = false;
     if (processorTaskRunning.compare_exchange_strong(exp, true)) {
         ExTask task = std::make_shared<DcpConsumerTask>(
-                &engine, shared_from_this(), 1);
+                &engine_, shared_from_this(), 1);
         processorTaskId = ExecutorPool::get()->schedule(task);
     }
 

engines/ep/src/dcp/consumer.h

@@ -540,8 +540,6 @@ class DcpConsumer : public ConnHandler,
             uint32_t opaque,
             std::unique_ptr<DcpResponse> msg);
 
-    /* Reference to the ep engine; need to create the 'Processor' task */
-    EventuallyPersistentEngine& engine;
     uint64_t opaqueCounter;
     size_t processorTaskId;
     std::atomic<enum process_items_error_t> processorTaskState;