Cleanup BinprotEWBCommand

Don't store the values in separate variables before
encoding them as part of encode and add members to
get/set the various fields

Change-Id: I618d733cf97ad8c1d093eeea1729577d7348109d
Reviewed-on: http://review.couchbase.org/c/kv_engine/+/138034
Tested-by: Build Bot <[email protected]>
Reviewed-by: Richard de Mellow <[email protected]>

Author: trondn

protocol/connection/client_mcbp_commands.cc

@@ -1877,17 +1877,13 @@ BinprotEWBCommand::BinprotEWBCommand(EWBEngineMode mode,
                                      ENGINE_ERROR_CODE err_code,
                                      uint32_t value,
                                      const std::string& key)
-    : BinprotGenericCommand(cb::mcbp::ClientOpcode::EwouldblockCtl, key),
-      mode(mode),
-      err_code(err_code),
-      value(value) {
-}
-
-void BinprotEWBCommand::encode(std::vector<uint8_t>& buf) const {
-    cb::mcbp::request::EWB_Payload extras;
+    : BinprotGenericCommand(cb::mcbp::ClientOpcode::EwouldblockCtl, key) {
     extras.setMode(uint32_t(mode));
     extras.setValue(uint32_t(value));
     extras.setInjectError(uint32_t(err_code));
+}
+
+void BinprotEWBCommand::encode(std::vector<uint8_t>& buf) const {
     writeHeader(buf, 0, sizeof(extras));
     auto extraBuf = extras.getBuffer();
     buf.insert(buf.end(), extraBuf.begin(), extraBuf.end());

protocol/connection/client_mcbp_commands.h

@@ -1111,10 +1111,27 @@ class BinprotEWBCommand : public BinprotGenericCommand {
 
     void encode(std::vector<uint8_t>& buf) const override;
 
+    uint32_t getMode() const {
+        return extras.getMode();
+    }
+    void setMode(uint32_t m) {
+        extras.setMode(m);
+    }
+    uint32_t getValue() const {
+        return extras.getValue();
+    }
+    void setValue(uint32_t v) {
+        extras.setValue(v);
+    }
+    uint32_t getInjectError() const {
+        return extras.getInjectError();
+    }
+    void setInjectError(uint32_t ie) {
+        extras.setInjectError(ie);
+    }
+
 protected:
-    EWBEngineMode mode;
-    ENGINE_ERROR_CODE err_code;
-    uint32_t value;
+    cb::mcbp::request::EWB_Payload extras;
 };
 
 class BinprotCompactDbCommand : public BinprotGenericCommand {