CBD-6348: [BP] clang-analyzer: Dereference of null pointer

After upgrade to clang-15 it warns that the parameter to the
constructor must not be null.

Change-Id: Ia474927a2b862ed854071f2b822c9a5b6e2fe8e4
Reviewed-on: https://review.couchbase.org/c/kv_engine/+/235156
Well-Formed: Restriction Checker
Tested-by: Trond Norbye <[email protected]>
Reviewed-by: Faizan Alam <[email protected]>
Reviewed-by: Vesko Karaganev <[email protected]>

Author: trondn

engines/crash_engine/crash_engine.cc

@@ -20,6 +20,7 @@
 #include <string>
 #include <thread>
 
+#include <fmt/format.h>
 #include <folly/lang/Assume.h>
 #include <memcached/config_parser.h>
 #include <memcached/engine.h>
@@ -71,24 +72,32 @@ class CrashEngine : public EngineIface {
      * means crashing it.
      */
     cb::engine_errc initialize(const std::string&) override {
-        std::string mode_string(getenv("MEMCACHED_CRASH_TEST"));
+        using namespace std::string_view_literals;
+        const auto* ptr = getenv("MEMCACHED_CRASH_TEST");
+        if (!ptr) {
+            fmt::print(
+                    stderr,
+                    "crash_engine::initialize: MEMCACHED_CRASH_TEST not set\n");
+            std::_Exit(EXIT_FAILURE);
+        }
+        std::string_view mode_string(ptr);
         CrashMode mode;
-        if (mode_string == "segfault") {
+        if (mode_string == "segfault"sv) {
             mode = CrashMode::SegFault;
-        } else if (mode_string == "std_exception") {
+        } else if (mode_string == "std_exception"sv) {
             mode = CrashMode::UncaughtStdException;
-        } else if (mode_string == "std_exception_via_std_thread") {
+        } else if (mode_string == "std_exception_via_std_thread"sv) {
             mode = CrashMode::UncaughtStdExceptionViaStdThread;
-        } else if (mode_string == "std_exception_with_trace") {
+        } else if (mode_string == "std_exception_with_trace"sv) {
             mode = CrashMode::UncaughtStdExceptionWithTrace;
-        } else if (mode_string == "unknown_exception") {
+        } else if (mode_string == "unknown_exception"sv) {
             mode = CrashMode::UncaughtUnknownException;
         } else {
-            fprintf(stderr,
-                    "crash_engine::initialize: could not find a valid "
-                    "CrashMode from MEMCACHED_CRASH_TEST env var ('%s')\n",
-                    mode_string.c_str());
-            exit(1);
+            fmt::print(stderr,
+                       "crash_engine::initialize: could not find a valid "
+                       "CrashMode from MEMCACHED_CRASH_TEST env var ({:?})\n",
+                       mode_string);
+            exit(EXIT_FAILURE);
         }
         if (mode == CrashMode::UncaughtStdExceptionViaStdThread) {
             std::thread thread{[mode] { recursive_crash_function(25, mode); }};