MB-40531: [BP] Make replica eviction ignore age threshold

Backport of http://review.couchbase.org/c/kv_engine/+/134805

Normally items above a configured MFU value
item_eviction_freq_counter_age_threshold
and below a configured age item_eviction_age_percentage are not
evicted.

This avoids evicting "young" items; their MFU counter might not
reflect how hot they are yet as they were only recently stored.

However, when evicting from replica vbuckets, this may not be as
beneficial. As active resident ratio has a direct impact on cache miss
rate and average latency, it may be better to evict even young replica
items to reclaim memory where possible, before considering active vbs.

Change-Id: Ic066f2231fad551ef2d04ee93126ac47181e6a15
Reviewed-on: http://review.couchbase.org/c/kv_engine/+/142503
Well-Formed: Build Bot <[email protected]>
Tested-by: Paolo Cocchi <[email protected]>
Reviewed-by: Trond Norbye <[email protected]>

Author: paolococchi

engines/ep/src/item_pager.cc

@@ -141,9 +141,25 @@ PagingVisitor::PagingVisitor(KVBucket& s,
             uint64_t age = (maxCas > v.getCas()) ? (maxCas - v.getCas()) : 0;
             age = age >> ItemEviction::casBitsNotTime;
 
-            if ((storedValueFreqCounter <= freqCounterThreshold) &&
-                    ((storedValueFreqCounter < freqCounterAgeThreshold)
-                            || (age >= ageThreshold))) {
+            const bool belowMFUThreshold =
+                    storedValueFreqCounter <= freqCounterThreshold;
+            // age exceeds threshold (from age histogram, set by config param
+            // item_eviction_age_percentage
+            // OR
+            // MFU is below threshold set by config param
+            // item_eviction_freq_counter_age_threshold
+            // Below this threshold the item is considered "cold" enough
+            // to be evicted even if it is "young".
+            const bool meetsAgeRequirements =
+                    age >= ageThreshold ||
+                    storedValueFreqCounter < freqCounterAgeThreshold;
+
+            // For replica vbuckets, young items are not protected from
+            // eviction.
+            const bool isReplica =
+                    currentBucket->getState() == vbucket_state_replica;
+
+            if (belowMFUThreshold && (meetsAgeRequirements || isReplica)) {
                 /*
                  * If the storedValue is eligible for eviction then add its
                  * frequency counter value to the histogram, otherwise add the