MB-32147: Add extra checks for last_modified existence

trondn · trondn · commit 29fa921a69f6 · 2019-01-14T10:00:42.000Z
The test currently fails with last_modified not being a string, but we have no clue if: a) It was present in the JSON at all b) what the type was Change-Id: I88a205dcc12d58a54fa8886fea23b2fb0af34d6d Reviewed-on: http://review.couchbase.org/103578 Reviewed-by: Dave Rigby <daver@couchbase.com> Tested-by: Trond Norbye <trond.norbye@gmail.com>
diff --git a/tests/testapp/testapp_xattr.cc b/tests/testapp/testapp_xattr.cc
@@ -873,7 +873,8 @@ TEST_P(XattrTest, MB_23882_VirtualXattrs) {
     EXPECT_TRUE(json["flags"].is_number());
 
     if (mcd_env->getTestBucket().supportsLastModifiedVattr()) {
-        EXPECT_TRUE(json["last_modified"].is_string());
+        EXPECT_NE(json.end(), json.find("last_modified"));
+        EXPECT_STREQ("string", json["last_modified"].type_name());
     }
 
     // Verify exptime is showing as 0 (document has no expiry)

Original file line number	Diff line number	Diff line change
`@@ -873,7 +873,8 @@ TEST_P(XattrTest, MB_23882_VirtualXattrs) {`
`873`	`873`	`EXPECT_TRUE(json["flags"].is_number());`
`874`	`874`
`875`	`875`	`if (mcd_env->getTestBucket().supportsLastModifiedVattr()) {`
`876`		`- EXPECT_TRUE(json["last_modified"].is_string());`
	`876`	`+ EXPECT_NE(json.end(), json.find("last_modified"));`
	`877`	`+ EXPECT_STREQ("string", json["last_modified"].type_name());`
`877`	`878`	`}`
`878`	`879`
`879`	`880`	`// Verify exptime is showing as 0 (document has no expiry)`