Skip to content

Commit 2aead9c

Browse files
owend74daverigby
authored andcommitted
MB-31664: Reapply - Switch over to not using backfill queue
The long-term plan is to remove the backfill queue. However, to gain confidence in the change prior to its removal we are disabling via the use of a switch. This switch over was originally done in commit 5968b4b (see http://review.couchbase.org/#/c/101275/) however it had to be reverted in commit 3386b90 (see http://review.couchbase.org/101684) because it was discovered that for a backfill, the checkpoint in the checkpointManager could become so large that we end up hitting an OOM condition. With the introducion of the ability to expel items from a checkpoints where all cursor have past, this should no longer occur. Therefore it should be safe to disable the use of the backfill queue. If after a period of time no issues are seen, the backfill queue and associated switch will be removed. Change-Id: I188cfbb48edbd4cf7279fa32f7933722e2d9577a Reviewed-on: http://review.couchbase.org/105643 Tested-by: Build Bot <[email protected]> Reviewed-by: Jim Walker <[email protected]>
1 parent db4a947 commit 2aead9c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

engines/ep/configuration.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,7 @@
350350
}
351351
},
352352
"disk_backfill_queue": {
353-
"default": "true",
353+
"default": "false",
354354
"descr": "True if we want to use the dedicated backfill queue for the first disk snapshot",
355355
"dynamic": true,
356356
"type": "bool"

0 commit comments

Comments
 (0)