[cluster_test] clang-tidy clustertest.*

* Some utility methods should be static
* Use the vbid passed as a parameter rather than vbid{0}
* const some variables

Change-Id: I0584dc96568358158b6382940c0136c82c3340b5
Reviewed-on: https://review.couchbase.org/c/kv_engine/+/203186
Tested-by: Build Bot <[email protected]>
Reviewed-by: Vesko Karaganev <[email protected]>

Author: trondn

tests/testapp_cluster/clustertest.cc

@@ -85,22 +85,23 @@ void cb::test::ClusterTest::TearDown() {
 }
 
 void cb::test::ClusterTest::getReplica(MemcachedConnection& conn,
-                                       Vbid vbid,
+                                       const Vbid vbid,
                                        const std::string& key) {
     BinprotResponse rsp;
     do {
         BinprotGenericCommand cmd(cb::mcbp::ClientOpcode::GetReplica);
-        cmd.setVBucket(Vbid(0));
+        cmd.setVBucket(vbid);
         cmd.setKey(key);
 
         rsp = conn.execute(cmd);
     } while (rsp.getStatus() == cb::mcbp::Status::KeyEnoent);
-    EXPECT_TRUE(rsp.isSuccess());
+    EXPECT_TRUE(rsp.isSuccess())
+            << rsp.getStatus() << ": " << rsp.getDataView();
 }
 
 cb::test::MemStats cb::test::ClusterTest::getMemStats(
         MemcachedConnection& conn) {
-    auto stats = conn.stats("memory");
+    const auto stats = conn.stats("memory");
     return MemStats{
             stats["mem_used"].get<size_t>(),
             stats["ep_mem_low_wat"].get<size_t>(),
@@ -111,12 +112,13 @@ cb::test::MemStats cb::test::ClusterTest::getMemStats(
 void cb::test::ClusterTest::setFlushParam(MemcachedConnection& conn,
                                           const std::string& paramName,
                                           const std::string& paramValue) {
-    auto cmd = BinprotSetParamCommand(
+    const auto cmd = BinprotSetParamCommand(
             cb::mcbp::request::SetParamPayload::Type::Flush,
             paramName,
             paramValue);
-    const auto resp = BinprotMutationResponse(conn.execute(cmd));
-    EXPECT_EQ(cb::mcbp::Status::Success, resp.getStatus());
+    const auto resp = conn.execute(cmd);
+    EXPECT_EQ(cb::mcbp::Status::Success, resp.getStatus())
+            << resp.getDataView();
 }
 
 void cb::test::ClusterTest::setMemWatermarks(MemcachedConnection& conn,

tests/testapp_cluster/clustertest.h

@@ -67,19 +67,19 @@ class ClusterTest : public ::testing::Test {
     // per test tear-down function.
     void TearDown() override;
 
-    void getReplica(MemcachedConnection& conn,
-                    Vbid vbid,
-                    const std::string& key);
+    static void getReplica(MemcachedConnection& conn,
+                           Vbid vbid,
+                           const std::string& key);
 
-    MemStats getMemStats(MemcachedConnection& conn);
+    static MemStats getMemStats(MemcachedConnection& conn);
 
-    void setFlushParam(MemcachedConnection& conn,
-                       const std::string& paramName,
-                       const std::string& paramValue);
+    static void setFlushParam(MemcachedConnection& conn,
+                              const std::string& paramName,
+                              const std::string& paramValue);
 
-    void setMemWatermarks(MemcachedConnection& conn,
-                          size_t memLowWat,
-                          size_t memHighWat);
+    static void setMemWatermarks(MemcachedConnection& conn,
+                                 size_t memLowWat,
+                                 size_t memHighWat);
 
     static std::unique_ptr<Cluster> cluster;
 };