[Cleanup] Simplify ServerCookieApi::set_priority

The underlying function will throw an exception if an invalid
priority is called so we don't need to run the checks twice

Change-Id: I45cf1493a7a7450d37e5a87c480571829f65f0ff
Reviewed-on: http://review.couchbase.org/c/kv_engine/+/141084
Tested-by: Build Bot <[email protected]>
Reviewed-by: Dave Rigby <[email protected]>

Author: trondn

daemon/server_api.cc

@@ -246,27 +246,9 @@ struct ServerCookieApi : public ServerCookieIface {
         return ENGINE_SUCCESS;
     }
 
-    void set_priority(gsl::not_null<const void*> void_cookie,
+    void set_priority(gsl::not_null<const void*> cookie,
                       ConnectionPriority priority) override {
-        auto* cookie = reinterpret_cast<const Cookie*>(void_cookie.get());
-
-        auto* c = &cookie->getConnection();
-        switch (priority) {
-        case ConnectionPriority::High:
-        case ConnectionPriority::Medium:
-        case ConnectionPriority::Low:
-            c->setPriority(priority);
-            return;
-        }
-
-        LOG_WARNING(
-                "{}: ServerCookieApi::set_priority: priority (which is {}) is "
-                "not a "
-                "valid CONN_PRIORITY - closing connection {}",
-                c->getId(),
-                int(priority),
-                c->getDescription());
-        c->shutdown();
+        getCookie(cookie).getConnection().setPriority(priority);
     }
 
     ConnectionPriority get_priority(