MB-47604: Check secondary callbacks not made by primary for getRange

We should check for secondary callbacks not made by the primary
in NexusKVStore::getRange.

Change-Id: I78adbb3eca48f3505aeec1119eb0f6e5002725ec
Reviewed-on: http://review.couchbase.org/c/kv_engine/+/163478
Tested-by: Build Bot <[email protected]>
Reviewed-by: James H <[email protected]>

Author: BenHuddleston

engines/ep/src/kvstore/nexus-kvstore/nexus-kvstore.cc

@@ -669,6 +669,21 @@ void NexusKVStore::getRange(Vbid vb,
         primaryGetValues.pop_front();
         secondaryGetValues.pop_front();
     }
+
+    if (!secondaryGetValues.empty()) {
+        std::stringstream ss;
+        for (auto& gv : secondaryGetValues) {
+            ss << *gv.item << ",";
+        }
+        ss.unget();
+
+        auto msg = fmt::format(
+                "NexusKVStore::getRange: {}: secondary callbacks not made by "
+                "primary:{}",
+                vb,
+                cb::UserData(ss.str()));
+        handleError(msg);
+    }
 }
 
 void NexusKVStore::del(TransactionContext& txnCtx, queued_item item) {