CBD-6348: Changes needed for gcc-13.2

Change-Id: Iae4c1e08d0e50c42d57fbedcfd8e5a9aa4e36eed
Reviewed-on: https://review.couchbase.org/c/kv_engine/+/234563
Reviewed-by: Vesko Karaganev <[email protected]>
Tested-by: Trond Norbye <[email protected]>
Well-Formed: Restriction Checker

Author: trondn

daemon/protocol/mcbp/get_cmd_timer_executor.cc

@@ -33,7 +33,7 @@ static std::pair<cb::engine_errc, Hdr1sfMicroSecHistogram> get_timings(
     // Don't create a new privilege context if the one we've got is for the
     // connected bucket:
     auto& connection = cookie.getConnection();
-    if (bucket.name == connection.getBucket().name) {
+    if (strcmp(bucket.name, connection.getBucket().name) == 0) {
         auto ret = mcbp::checkPrivilege(cookie,
                                         cb::rbac::Privilege::SimpleStats);
         if (ret != cb::engine_errc::success) {

engines/ep/src/dcp/passive_stream.cc

@@ -657,7 +657,7 @@ cb::engine_errc PassiveStream::processMessage(MutationConsumerMessage* message,
         message->getItem()->setCas();
     }
 
-    cb::engine_errc ret;
+    cb::engine_errc ret = cb::engine_errc::failed;
     DeleteSource deleteSource = DeleteSource::Explicit;
     bool switchComplete = false;
     switch (messageType) {

engines/ep/tests/mock/mock_kvstore.cc

@@ -51,7 +51,7 @@ MockKVStore::MockKVStore(std::unique_ptr<KVStoreIface> real)
         ON_CALL(*this, getAggrDbFileInfo()).WillByDefault([this]() {
             return this->realKVS->getAggrDbFileInfo();
         });
-        ON_CALL(*this, getConfig()).WillByDefault([this]() {
+        ON_CALL(*this, getConfig()).WillByDefault([this]() -> const auto& {
             return this->realKVS->getConfig();
         });
         ON_CALL(*this, snapshotVBucket(_, _))

include/mcbp/protocol/opcode.h

@@ -12,6 +12,7 @@
 
 #include <iosfwd>
 #include <string>
+#include <cstdint>
 
 namespace cb::mcbp {